eng, use ESRP for typespec-java release#3324
Merged
weidongxu-microsoft merged 4 commits intomainfrom Apr 20, 2026
Merged
Conversation
weidongxu-microsoft
requested review from
XiaofeiCao,
haolingdong-msft and
srnagar
as code owners
raych1
approved these changes
Apr 15, 2026
Comment on lines
+68
to
+71
| - pwsh: | | ||
| New-Item -ItemType Directory -Path "$(buildArtifactsPath)/packages" -Force | ||
| Copy-Item -Path "./typespec-extension/*.tgz" -Destination "$(buildArtifactsPath)/packages" | ||
| displayName: 'Copy packages to artifacts staging directory' |
Member
Author
There was a problem hiding this comment.
Add step to create $(buildArtifactsPath)/packages and copy package there.
Comment on lines
+73
to
+87
| # Always publish to internal feed | ||
| - template: /eng/pipelines/templates/steps/create-authenticated-npmrc.yml | ||
| parameters: | ||
| npmrcPath: $(buildArtifactsPath)/packages/.npmrc | ||
| registryUrl: https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-js/npm/registry/ | ||
|
|
||
| # publish to devops feed | ||
| - pwsh: | | ||
| $packageFiles = Get-ChildItem -Path . -Filter '*.tgz' | ||
| foreach ($file in $packageFiles.Name) { | ||
| Write-Host "npm publish $file --verbose --access public" | ||
| npm publish $file --verbose --access public | ||
| } | ||
| displayName: Publish to DevOps feed | ||
| workingDirectory: $(buildArtifactsPath)/packages |
Member
Author
There was a problem hiding this comment.
Add step to publish to DevOps feed (same as microsoft/typespec)
Member
Author
raych1
reviewed
Apr 17, 2026
| Copy-Item -Path "./typespec-extension/*.tgz" -Destination "$(buildArtifactsPath)/packages" | ||
| displayName: 'Copy packages to artifacts staging directory' | ||
|
|
||
| # Always publish to internal feed |
Member
There was a problem hiding this comment.
Nit: change comment to something like "create npmrc file with auth" to avoid confusion.
raych1
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we may want to add the "publish to devop" step too
microsoft/typespec#10292
combined test branch https://github.com/Azure/autorest.java/tree/eng_cfs%2Besrp