fixes inconsistency in max_execution_time#2841
Merged
Conversation
|
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
Member
|
@claude review |
|
Claude finished @mshustov's task in 3m 2s —— View job PR Review: fixes inconsistency in max_execution_time
SummaryThe PR correctly fixes a bug in The fix is correct and targeted. A few observations below. Findings1. Scope of the bug was limited to The other two callers at lines 1821 and 1886 already used 2. // ClientConfigProperties.java:102
MAX_EXECUTION_TIME("max_execution_time", Integer.class, "0"),
3. Missing behavioral test The PR checklist marks "Unit and integration tests" as done, but the diff shows only two files changed ( 4. Javadoc default description The updated comment says 5.
VerdictThe fix is correct and safe to merge as-is. The only actionable item before merging is removing the checked "Unit and integration tests" checklist item (or adding an actual behavioral test), to avoid misleading future readers of the PR history. |
mshustov
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an inconsistency in how the executionTimeout parameter is handled in the client-v2 component, addressing Issue #2358.
Previously, the timeout was correctly saved in milliseconds by the builder, but was mistakenly retrieved and applied as seconds in getOperationTimeout() and Client.java's future get(...) methods. This caused operations to time out prematurely (or wait significantly longer than expected).
Changes:
Updated getOperationTimeout() to document and return the value correctly in milliseconds.
Updated CompletableFuture.get(...) calls to consistently use TimeUnit.MILLISECONDS instead of TimeUnit.SECONDS.
Updated exception messages to state the timeout accurately in milliseconds.
Closes #2358
Checklist
Delete items not relevant to your PR: