Conversation
Member
Author
|
@gnapse I need your help to fix or ignore remaining violations - and also review if the ignores I did make sense. |
proxi
force-pushed
the
proxi/eslint-config
branch
from
7d053ea to
4e228ac
Compare
proxi
force-pushed
the
proxi/eslint-config
branch
from
4e228ac to
176912a
Compare
Member
Author
|
@Doist/frontend Could anyone help wrapping this up? |
Contributor
|
Saw this and added it to my list, hope to get it in before the end of the week 🙌 |
Contributor
|
@proxi pushed a couple of commits to make this green, please review this before merging 👍 |
Member
Author
|
@henningmu Tests are passing and you already had a look, and Ernesto is OOO, so I'm merging without approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Adopt @doist/eslint-config. WIP.
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonnpm run build-all)Versioning
It is internal cleanup, no need to release.