Merged
Conversation
frankieyan
approved these changes
Mar 30, 2021
444b943 to
540f3fe
Compare
Contributor
Author
|
@frankieyan any idea why the new package version has not been published yet? It seems more than enough time since I merged this. And I do not see the publish action triggered. |
Member
|
The action is run when a release is created 👍 |
Contributor
Author
|
Ah, I thought a push was enough. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
A
MenuItemelement should support receiving aonClickevent handler. A good motivation to do it is to catch the click event early, and possibly callevent.preventDefault(), which should prevent the menu item's selection action to happen.PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refnpm run build-all)Versioning
I consider this a bug fix, since the
onClickhandler is already supported in the prop types, but we were not calling it internally. Hence this marks a new patch release.