Skip to content

feat: Updates Avatar to support responsive patterns#611

Merged
scottlovegrove merged 12 commits intomainfrom
scottl/avatar
Nov 22, 2021
Merged

feat: Updates Avatar to support responsive patterns#611
scottlovegrove merged 12 commits intomainfrom
scottl/avatar

Conversation

@scottlovegrove
Copy link
Copy Markdown
Contributor

Closes #605

Short description

Updates the Avatar component to use the newer way of doing reactist components, using css variables etc. It also adds the abaility to use the responsive elements that have been introduced with v11 so that an avatar's size can dynamically change based on the screen size.

One thing to note, I have intentionally left the size values as is otherwise this would have resulted in a breaking change.

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Updated all static build artifacts (npm run build-all)

Versioning

Left versioning alone, it can be released when one is next done.

@scottlovegrove scottlovegrove requested review from a team and gnapse November 16, 2021 15:00
@scottlovegrove scottlovegrove self-assigned this Nov 16, 2021
Comment thread src/new-components/avatar/avatar.module.css Outdated
Comment thread src/new-components/avatar/avatar.module.css Outdated
Comment thread src/new-components/avatar/avatar.tsx Outdated
Comment thread src/index.ts Outdated
Comment thread src/new-components/avatar/avatar.tsx Outdated
Comment thread src/new-components/avatar/avatar.test.tsx Outdated
Comment thread src/new-components/avatar/avatar.test.tsx Outdated
Comment thread src/new-components/avatar/avatar.test.tsx Outdated
Comment thread src/new-components/avatar/avatar.test.tsx Outdated
Comment thread src/new-components/avatar/avatar.tsx Outdated
@gnapse
Copy link
Copy Markdown
Contributor

gnapse commented Nov 22, 2021

@scottlovegrove you marked my latest comments as resolved, but I do not see any new changes having been pushed after them. Perhaps you forgot to push something?

@scottlovegrove
Copy link
Copy Markdown
Contributor Author

@scottlovegrove you marked my latest comments as resolved, but I do not see any new changes having been pushed after them. Perhaps you forgot to push something?

@gnapse I was waiting for an answer about the snapshot tests and whether I should just remove them.

@gnapse
Copy link
Copy Markdown
Contributor

gnapse commented Nov 22, 2021

I do not see value on them in this case, especially in the cases where I commented (the ones where you are already making an extra assertion that validates what's described in the test case title).

@scottlovegrove
Copy link
Copy Markdown
Contributor Author

scottlovegrove commented Nov 22, 2021

I do not see value on them in this case, especially in the cases where I commented (the ones where you are already making an extra assertion that validates what's described in the test case title).

I have removed them then and pushed the changes for which I'd marked your comments as resolved.

@scottlovegrove scottlovegrove merged commit 75526d5 into main Nov 22, 2021
@scottlovegrove scottlovegrove deleted the scottl/avatar branch November 22, 2021 18:01
@gnapse gnapse mentioned this pull request Jan 5, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avatar: Allow responsive sizes

2 participants