fix: Ensure Tooltips work with anchors that have an as prop#684
Merged
frankieyan merged 2 commits intomainfrom Aug 19, 2022
Merged
fix: Ensure Tooltips work with anchors that have an as prop#684frankieyan merged 2 commits intomainfrom
as prop#684frankieyan merged 2 commits intomainfrom
Conversation
d1743cb to
e528fd7
Compare
as prop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This fixes an issue where if you used a tooltip anchor with an
asprop, it gets doubly applied, creates a nested element, and loses the anchor's children in the process 😬Example:
...would result in something like:
You could test this in storybook by undoing the fix, then using
<Box as={Button}>as an anchor.PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refnpm run build-all)Versioning
Patch release