fix: TextArea now controls the width and only allows resizing vertically#695
Merged
fix: TextArea now controls the width and only allows resizing vertically#695
Conversation
jvalente
approved these changes
Sep 1, 2022
fc12620 to
27627de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Fixes an issue that @engfragui brought up before in the context of their use of Reactist TextArea in the adaptive cards components. The issue then was resolved differently, due to certain circumstances with adaptive cards. But the issue remained. Now it appears again, and it's blocking me from merging https://github.com/Doist/todoist-web/pull/4988.
So here's the fix.
What's the problem and the fix
The text area is incompatible with horizontal resizing alongside us wanting it to stretch horizontally, which is what we want most of the time. This very text area in GitHub where I'm typing this has the same problem. So the fix was to add
width: 100%; resize: vertical;to the<textarea />element of the<TextArea />component. Everything else in the diff is not about the fix, but a refactor of the CSS modules class name and adding a missing value in storybooks.PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refnpm run build-all)Versioning
A patch release is enough.