Skip to content

fix: TextArea now controls the width and only allows resizing vertically#695

Merged
gnapse merged 1 commit intomainfrom
ernesto/fix-textarea-width
Sep 1, 2022
Merged

fix: TextArea now controls the width and only allows resizing vertically#695
gnapse merged 1 commit intomainfrom
ernesto/fix-textarea-width

Conversation

@gnapse
Copy link
Copy Markdown
Contributor

@gnapse gnapse commented Aug 31, 2022

Short description

Fixes an issue that @engfragui brought up before in the context of their use of Reactist TextArea in the adaptive cards components. The issue then was resolved differently, due to certain circumstances with adaptive cards. But the issue remained. Now it appears again, and it's blocking me from merging https://github.com/Doist/todoist-web/pull/4988.

So here's the fix.

What's the problem and the fix

The text area is incompatible with horizontal resizing alongside us wanting it to stretch horizontally, which is what we want most of the time. This very text area in GitHub where I'm typing this has the same problem. So the fix was to add width: 100%; resize: vertical; to the <textarea /> element of the <TextArea /> component. Everything else in the diff is not about the fix, but a refactor of the CSS modules class name and adding a missing value in storybooks.

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Updated all static build artifacts (npm run build-all)

Versioning

A patch release is enough.

@gnapse gnapse requested a review from a team August 31, 2022 18:44
@gnapse gnapse self-assigned this Aug 31, 2022
@gnapse gnapse requested review from jvalente and removed request for a team August 31, 2022 18:44
@gnapse gnapse force-pushed the ernesto/fix-textarea-width branch from fc12620 to 27627de Compare September 1, 2022 12:54
@gnapse gnapse merged commit beadad7 into main Sep 1, 2022
@gnapse gnapse deleted the ernesto/fix-textarea-width branch September 1, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants