Skip to content

fix: Ensure TextArea autoExpand is acknowledged on its initial value#772

Merged
gnapse merged 1 commit intomainfrom
ernesto/textarea-autoexpand-initially
May 19, 2023
Merged

fix: Ensure TextArea autoExpand is acknowledged on its initial value#772
gnapse merged 1 commit intomainfrom
ernesto/textarea-autoexpand-initially

Conversation

@gnapse
Copy link
Copy Markdown
Contributor

@gnapse gnapse commented May 19, 2023

Closes #771

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Updated all static build artifacts (npm run build-all)
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Patch release.

@gnapse gnapse requested a review from pawelgrimm May 19, 2023 03:58
@gnapse gnapse self-assigned this May 19, 2023
@gnapse gnapse force-pushed the ernesto/textarea-autoexpand-initially branch from ca4205c to 6b078b7 Compare May 19, 2023 04:01
@gnapse gnapse force-pushed the ernesto/textarea-autoexpand-initially branch from 6b078b7 to 809fe91 Compare May 19, 2023 04:09
@gnapse gnapse force-pushed the ernesto/textarea-autoexpand-initially branch from 809fe91 to 405a75f Compare May 19, 2023 04:11
Copy link
Copy Markdown
Contributor

@pawelgrimm pawelgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach makes a lot more sense than what I was trying to do 😅 Great work and thanks for the quick fix! 🚀

@gnapse gnapse merged commit 8cd467d into main May 19, 2023
@gnapse gnapse deleted the ernesto/textarea-autoexpand-initially branch May 19, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A controlled TextArea with autoExpand doesn't resize correctly on initial render

2 participants