Skip to content

feat: Use link colors when inline code is wrapped in links#785

Merged
frankieyan merged 3 commits intomainfrom
frankie/update-prose-code-links
Jun 20, 2023
Merged

feat: Use link colors when inline code is wrapped in links#785
frankieyan merged 3 commits intomainfrom
frankie/update-prose-code-links

Conversation

@frankieyan
Copy link
Copy Markdown
Member

@frankieyan frankieyan commented Jun 16, 2023

Short description

This will update the Prose component to apply link styles to inline code that are wrapped in a link.

This should be updated in conjunction with Doist/typist#309.

Before After
image image

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Minor

@frankieyan frankieyan requested review from a team and craigcarlyle and removed request for a team June 16, 2023 23:21
@frankieyan frankieyan self-assigned this Jun 16, 2023
Copy link
Copy Markdown
Contributor

@craigcarlyle craigcarlyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@frankieyan frankieyan merged commit f08662b into main Jun 20, 2023
@frankieyan frankieyan deleted the frankie/update-prose-code-links branch June 20, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants