feat: Expose input border colours as --reactist-inputs-* variables#790
Merged
frankieyan merged 8 commits intomainfrom Jul 10, 2023
Merged
feat: Expose input border colours as --reactist-inputs-* variables#790frankieyan merged 8 commits intomainfrom
frankieyan merged 8 commits intomainfrom
Conversation
Bloomca
approved these changes
Jul 6, 2023
Contributor
Bloomca
left a comment
There was a problem hiding this comment.
Change looks good. I am not sure what I need (if I need to do anything) on Chromatic, though.
Member
Author
Contributor
We should not keep a name only because of Chromatic. If we really find the name change to be what we want, we should do the change, even if inconvenient. I do agree the name change is for the better. |
1460a43 to
cf995a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Short description
This separates the CSS variables used for dividers and graphical elements' borders, from those used for input fields' borders.
To document these variables in Storybook, the four field-based components have had their documentation converted to MDX:
By having this separation, we'd be able to take advantage of the new
inputscolours from Design (ref).PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refVersioning
Minor. It's a bit of a grey area as the new variables are instantiated with the old
--reactist-dividercolours, keeping backwards compatibility, and existing overrides using these variables should not break.