revert: Modal alignment to middle at breakpoint adjustment#823
Merged
revert: Modal alignment to middle at breakpoint adjustment#823
Conversation
nats12
added a commit
that referenced
this pull request
May 31, 2024
* feat: Add 'medium' weight to Heading (#814) * feat: Add 'medium' weight to Heading * Update changelog * Bump version * fix: Adjust modal alignment to middle at breakpoint (#821) * revert: Modal alignment to middle at breakpoint adjustment (#823) ref: 3aefefb * feat: Add warning tone for Badge (#826) ## Short description Adds a new `warning` variant for the Badge component's `tone` option. <img width="281" alt="Screenshot 2024-05-28 at 11 30 36" src="https://github.com/Doist/reactist/assets/15801768/b829b743-6356-4932-8b00-ab4a34d44769"> ## PR Checklist <!-- Feel free to leave unchecked or remove the lines that are not applicable. --> - [x] Added tests for bugs / new features - [x] Updated docs (storybooks, readme) - [x] Executed `npm run validate` and made sure no errors / warnings were shown - [x] Described changes in `CHANGELOG.md` - [x] Bumped version in `package.json` and `package-lock.json` (`npm --no-git-tag-version version <major|minor|patch>`) [ref](https://docs.npmjs.com/cli/v6/commands/npm-version) - [x] Reviewed and approved Chromatic visual regression tests in CI ## Versioning Minor * chore: Bump up version to v23.3.0 (#827) --------- Co-authored-by: Frankie Yan <frankieyan@users.noreply.github.com> Co-authored-by: Ricardo Amaral <ricardo@doist.com> Co-authored-by: Ernesto García <ernesto@doist.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This reverts #821 because it turns out that this is not something that we want to do.
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refVersioning
Patch