Conversation
|
@nats12 The code change looks sane to me 👌 The only thing I noticed is that the colors are the same for both light and dark mode versions, which I find unusual...
I'm assuming this new Badge tone has been requested by Design team? 🤔 |
engfragui
left a comment
There was a problem hiding this comment.
Code change looks correct so approving. Raised a small note re: colors in light and dark mode, but otherwise good to go in case it's confirmed that the colors are as intended by the Desing team 👌
@engfragui indeed, see convo here about the latest token style, and adding it to this component.
I believe dark mode isn't supported for these components, so those aren't the actual dark mode styles that would be applied. That screenshot illustrates an example from the docs on how to style them differently. It seems most are inverted, with a slightly darker tint than in light mode, I'll do the same for warning:
Thanks for raising! 🙌🏼 |
* feat: Add 'medium' weight to Heading (#814) * feat: Add 'medium' weight to Heading * Update changelog * Bump version * fix: Adjust modal alignment to middle at breakpoint (#821) * revert: Modal alignment to middle at breakpoint adjustment (#823) ref: 3aefefb * feat: Add warning tone for Badge (#826) ## Short description Adds a new `warning` variant for the Badge component's `tone` option. <img width="281" alt="Screenshot 2024-05-28 at 11 30 36" src="https://github.com/Doist/reactist/assets/15801768/b829b743-6356-4932-8b00-ab4a34d44769"> ## PR Checklist <!-- Feel free to leave unchecked or remove the lines that are not applicable. --> - [x] Added tests for bugs / new features - [x] Updated docs (storybooks, readme) - [x] Executed `npm run validate` and made sure no errors / warnings were shown - [x] Described changes in `CHANGELOG.md` - [x] Bumped version in `package.json` and `package-lock.json` (`npm --no-git-tag-version version <major|minor|patch>`) [ref](https://docs.npmjs.com/cli/v6/commands/npm-version) - [x] Reviewed and approved Chromatic visual regression tests in CI ## Versioning Minor * chore: Bump up version to v23.3.0 (#827) --------- Co-authored-by: Frankie Yan <frankieyan@users.noreply.github.com> Co-authored-by: Ricardo Amaral <ricardo@doist.com> Co-authored-by: Ernesto García <ernesto@doist.com>



Short description
Adds a new
warningvariant for the Badge component'stoneoption.PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refVersioning
Minor