Skip to content

fix: Better icon alignment for the Notice component#848

Merged
rfgamaral merged 1 commit intomainfrom
ricardo/align-notice-icon
Nov 11, 2024
Merged

fix: Better icon alignment for the Notice component#848
rfgamaral merged 1 commit intomainfrom
ricardo/align-notice-icon

Conversation

@rfgamaral
Copy link
Copy Markdown
Member

@rfgamaral rfgamaral commented Nov 11, 2024

Short description

This fixes the vertical alignment for icons in the Notice component (https://github.com/Doist/Issues/issues/15416).

PR Checklist

  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Patch

@rfgamaral rfgamaral added the 👀 Show PR Used for PRs that need a review, but can be merged when CI is green. label Nov 11, 2024
@rfgamaral rfgamaral requested a review from a team November 11, 2024 11:09
@rfgamaral rfgamaral self-assigned this Nov 11, 2024
@rfgamaral rfgamaral requested review from gnapse and removed request for a team November 11, 2024 11:09
@rfgamaral rfgamaral merged commit 5fee496 into main Nov 11, 2024
@rfgamaral rfgamaral deleted the ricardo/align-notice-icon branch November 11, 2024 11:17
Copy link
Copy Markdown
Contributor

@gnapse gnapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👀 Show PR Used for PRs that need a review, but can be merged when CI is green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants