Skip to content

feat: add BaseService.constructServiceURL method#122

Merged
padamstx merged 2 commits intomainfrom
support_parameterized_url
May 18, 2021
Merged

feat: add BaseService.constructServiceURL method#122
padamstx merged 2 commits intomainfrom
support_parameterized_url

Conversation

@ajhynes7
Copy link
Copy Markdown
Contributor

This static method can be used by generated code.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 17, 2021

CLA assistant check
All committers have signed the CLA.

@ajhynes7 ajhynes7 requested a review from padamstx May 17, 2021 18:37
This static method can be used by generated code.
@ajhynes7 ajhynes7 force-pushed the support_parameterized_url branch from 34a9804 to 1a550bb Compare May 17, 2021 19:08
Copy link
Copy Markdown
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. However, let's hold off on merging this until we finish the end-to-end scenario for Java (i.e. generator changes tested via systest framework... we can discuss the details here).

@padamstx padamstx merged commit 76eda02 into main May 18, 2021
@padamstx padamstx deleted the support_parameterized_url branch May 18, 2021 19:51
ibm-devx-sdk pushed a commit that referenced this pull request May 18, 2021
# [9.10.0](9.9.1...9.10.0) (2021-05-18)

### Features

* add `BaseService.constructServiceURL` method ([#122](#122)) ([76eda02](76eda02))
@ibm-devx-sdk
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 9.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants