Skip to content

fix: set visibility of ConfigBasedAuthenticatorFactory.createAuthenticator to protected#165

Merged
padamstx merged 1 commit intomainfrom
auth-factory-protected
Feb 21, 2022
Merged

fix: set visibility of ConfigBasedAuthenticatorFactory.createAuthenticator to protected#165
padamstx merged 1 commit intomainfrom
auth-factory-protected

Conversation

@padamstx
Copy link
Copy Markdown
Contributor

This commit changes the visibility of the
"ConfigBasedAuthenticatorFactory.createAuthenticator()" method from
private to protected to allow SDKs to override this class
in order to support alternate configuration sources
(e.g. injected spring properties).

…cator to protected

This commit changes the visibility of the
"ConfigBasedAuthenticatorFactory.createAuthenticator()" method from
private to protected to allow SDKs to override this class
in order to support alternate configuration sources
(e.g. injected spring properties).
@padamstx padamstx requested a review from dpopp07 February 18, 2022 18:47
@padamstx padamstx self-assigned this Feb 18, 2022
Copy link
Copy Markdown
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@padamstx padamstx merged commit ef1ef9a into main Feb 21, 2022
@padamstx padamstx deleted the auth-factory-protected branch February 21, 2022 15:19
ibm-devx-sdk pushed a commit that referenced this pull request Feb 21, 2022
## [9.15.4](9.15.3...9.15.4) (2022-02-21)

### Bug Fixes

* set visibility of ConfigBasedAuthenticatorFactory.createAuthenticator to protected ([#165](#165)) ([ef1ef9a](ef1ef9a))
@ibm-devx-sdk
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 9.15.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants