fix(ContainerAuthenticator): add sa-token as default CR token filename#202
Merged
fix(ContainerAuthenticator): add sa-token as default CR token filename#202
Conversation
dpopp07
approved these changes
May 22, 2023
Contributor
dpopp07
left a comment
dpopp07
left a comment
There was a problem hiding this comment.
Looks good and confirmed with internal cluster 👍
This commit adds support for a second default CR token filename. If the user doesn't specify a CR token filename, the authenticator will first try '/var/run/secrets/tokens/vault-token', and then '/var/run/secrets/tokens/sa-token' in that order. Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
padamstx
force-pushed
the
add-default-filename
branch
from
3e7be5d to
3b59728
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
May 22, 2023
## [9.18.3](9.18.2...9.18.3) (2023-05-22) ### Bug Fixes * **ContainerAuthenticator:** add sa-token as default CR token filename ([#202](#202)) ([593244a](593244a))
Contributor
|
🎉 This PR is included in version 9.18.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for a second default CR token filename. If the user doesn't specify a CR token filename, the authenticator will first try '/var/run/secrets/tokens/vault-token', and then '/var/run/secrets/tokens/sa-token' in that order.