Skip to content

feat(MCSPAuthenticator): add new authenticator for Multi-Cloud Saas Platform#217

Merged
padamstx merged 1 commit intomainfrom
mcsp-authenticator
Nov 15, 2023
Merged

feat(MCSPAuthenticator): add new authenticator for Multi-Cloud Saas Platform#217
padamstx merged 1 commit intomainfrom
mcsp-authenticator

Conversation

@padamstx
Copy link
Copy Markdown
Contributor

@padamstx padamstx commented Nov 8, 2023

This commit introduces the new MCSPAuthenticator that can be used to exchange an apikey for an MCSP access token using the Multi-Cloud Saas Platform authentication token server's 'POST /siusermgr/api/1.0/apikeys/token' operation.

@padamstx padamstx self-assigned this Nov 8, 2023
@padamstx padamstx marked this pull request as ready for review November 8, 2023 23:40
assertEquals(authenticator.getClient(), client);

// Authenticator should request new, valid token.
Request.Builder requestBuilder = new Request.Builder().url("https://test.com");
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was for you, @pyrooka 😂

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, much appreciated!

…latform

This commit introduces the new MCSPAuthenticator that can be used
to exchange an apikey for an MCSP access token using the Multi-Cloud Saas Platform
authentication token server's 'POST /siusermgr/api/1.0/apikeys/token' operation.

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
Copy link
Copy Markdown
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look pretty good - as far as I can tell!

assertEquals(authenticator.getClient(), client);

// Authenticator should request new, valid token.
Request.Builder requestBuilder = new Request.Builder().url("https://test.com");
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, much appreciated!

Copy link
Copy Markdown
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@padamstx padamstx merged commit da0b4be into main Nov 15, 2023
@padamstx padamstx deleted the mcsp-authenticator branch November 15, 2023 17:56
ibm-devx-sdk pushed a commit that referenced this pull request Nov 15, 2023
# [9.19.0](9.18.7...9.19.0) (2023-11-15)

### Features

* **MCSPAuthenticator:** add new authenticator for Multi-Cloud Saas Platform ([#217](#217)) ([da0b4be](da0b4be))
@ibm-devx-sdk
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 9.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants