Skip to content

feat(IamAssumeAuthenticator): introduce new authenticator type#227

Merged
padamstx merged 2 commits intomainfrom
iam-assume
Oct 15, 2024
Merged

feat(IamAssumeAuthenticator): introduce new authenticator type#227
padamstx merged 2 commits intomainfrom
iam-assume

Conversation

@padamstx
Copy link
Copy Markdown
Contributor

@padamstx padamstx commented Oct 1, 2024

This commit introduces the new IamAssumeAuthenticator which will fetch an IAM access token using the IAM getToken operation's "assume" grant type. The resulting access token allows the application to assume the identity of a trusted profile, similar to the "sudo" feature of Linux.

@padamstx padamstx self-assigned this Oct 1, 2024
@padamstx padamstx force-pushed the iam-assume branch 2 times, most recently from 9cc61e0 to 5192fea Compare October 1, 2024 20:15
Copy link
Copy Markdown
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one thing I'd like to mention: in the Authentication.md I found 4 typos - outside of you changes. It's the verificaton. If you think you can fix those in this PR, totally up to you. :)

Comment thread Authentication.md Outdated
This commit introduces the new IamAssumeAuthenticator which
will fetch an IAM access token using the IAM getToken operation's
"assume" grant type.  The resulting access token allows the
application to assume the identity of a trusted profile,
similar to the "sudo" feature of Linux.

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
@padamstx
Copy link
Copy Markdown
Contributor Author

padamstx commented Oct 2, 2024

in the Authentication.md I found 4 typos

fixed

Copy link
Copy Markdown
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
@padamstx
Copy link
Copy Markdown
Contributor Author

Just pushed the commit with the immutable-related changes. I'll request a re-review...

@padamstx padamstx requested review from dpopp07 and pyrooka October 10, 2024 19:40
Copy link
Copy Markdown
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good!

Copy link
Copy Markdown
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@padamstx padamstx merged commit 35abbf0 into main Oct 15, 2024
@padamstx padamstx deleted the iam-assume branch October 15, 2024 14:12
ibm-devx-sdk pushed a commit that referenced this pull request Oct 15, 2024
# [9.22.0](9.21.2...9.22.0) (2024-10-15)

### Features

* **IamAssumeAuthenticator:** introduce new authenticator type ([#227](#227)) ([35abbf0](35abbf0))
@ibm-devx-sdk
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 9.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants