feat: support service configuration via system properties#79
feat: support service configuration via system properties#79
Conversation
| files.add(new File(userSpecifiedPath)); | ||
| } | ||
|
|
||
| if (StringUtils.isNotEmpty(userSpecifiedSystemProp)) { |
There was a problem hiding this comment.
I couldn't move this to the end because unit tests would fail due to them finding other credential files in the java-core root directory
There was a problem hiding this comment.
yeah, I think this is fine. If the user sets IBM_CREDENTIALS_FILE as an env var OR a system property, i think the intent is clear that they want to specify the custom filename as an override to any of the standard names we may look for.
jorge-ibm
force-pushed
the
support-system-properties
branch
from
c10b00f to
e4a027e
Compare
padamstx
left a comment
padamstx
left a comment
There was a problem hiding this comment.
LGTM; I made one minor comment but I don't think it affects functionality at all.
| files.add(new File(userSpecifiedPath)); | ||
| } | ||
|
|
||
| if (StringUtils.isNotEmpty(userSpecifiedSystemProp)) { |
There was a problem hiding this comment.
yeah, I think this is fine. If the user sets IBM_CREDENTIALS_FILE as an env var OR a system property, i think the intent is clear that they want to specify the custom filename as an override to any of the standard names we may look for.
jorge-ibm
force-pushed
the
support-system-properties
branch
from
e4a027e to
6e11d4a
Compare
# [8.2.0](8.1.5...8.2.0) (2020-05-11) ### Features * support service config via system properties ([#79](#79)) ([d5e7a27](d5e7a27))
|
🎉 This PR is included in version 8.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3 participants
ref: https://github.ibm.com/arf/planning-sdk-squad/issues/1762
Changes: