Merged
Conversation
padamstx
previously approved these changes
Sep 14, 2020
jorge-ibm
force-pushed
the
fix/token-refresh-logic
branch
from
e2a8f35 to
9594b5d
Compare
ibm-devx-automation
pushed a commit
that referenced
this pull request
Sep 14, 2020
## [9.2.1](9.2.0...9.2.1) (2020-09-14) ### Bug Fixes * iam/cp4d token refresh logic ([#91](#91)) ([f0484a5](f0484a5))
|
🎉 This PR is included in version 9.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to IBM/go-sdk-core#73, this PR simply fixes the flaw in the token refresh logic described in https://github.ibm.com/arf/planning-sdk-squad/issues/2149 by updating the new
refreshTimecalculation to be 1 minute ahead of the current time vs 1 minute ahead of the previousrefreshTimevalue.