This repository was archived by the owner on Dec 20, 2024. It is now read-only.
Merged
Conversation
ralphtheninja
commented
May 12, 2018
| "test": "tape test/*.js && standard" | ||
| }, | ||
| "engines": { | ||
| "node": ">=4" |
Member
Author
There was a problem hiding this comment.
Updating node version in another PR.
vweevers
reviewed
May 12, 2018
| The `type` string should be a unique name. | ||
|
|
||
| ## License & copyright | ||
| ## License & Copyright |
vweevers
reviewed
May 12, 2018
| ## API | ||
|
|
||
| ### Codec([opts]) | ||
| ### `const codec = Codec([opts])` |
Member
There was a problem hiding this comment.
Why const? Doesn't mean anything here, I think.
vweevers
reviewed
May 12, 2018
| This could be something like | ||
| ### `codec.encodeKey(key[, opts])` | ||
|
|
||
| ```js |
Member
There was a problem hiding this comment.
We should add an Example section
vweevers
reviewed
May 12, 2018
| ### `codec.createStreamDecoder([opts])` | ||
|
|
||
| Create a function with signature `(key, value)`, that for each key/value pair returned from a levelup read stream returns the decoded value to be emitted. | ||
| Create a function with signature `(key, value)`, that for each key/value pair returned from a levelup read stream returns the decoded value to be emitted. |
Member
There was a problem hiding this comment.
key/value pair => key-value pair
added 3 commits
May 12, 2018 10:38
vweevers
approved these changes
May 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28