From 011520a0862cd2ff820b83a76c8c79f3cec9fd3e Mon Sep 17 00:00:00 2001 From: irgendeinich Date: Tue, 5 Jan 2021 09:53:28 +0100 Subject: [PATCH 1/2] Fix stamps not being correctly detected --- .../main/java/com/pspdfkit/react/helper/ConversionHelpers.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/android/src/main/java/com/pspdfkit/react/helper/ConversionHelpers.java b/android/src/main/java/com/pspdfkit/react/helper/ConversionHelpers.java index 5f296765..8b7929e3 100644 --- a/android/src/main/java/com/pspdfkit/react/helper/ConversionHelpers.java +++ b/android/src/main/java/com/pspdfkit/react/helper/ConversionHelpers.java @@ -51,6 +51,9 @@ public static EnumSet getAnnotationTypeFromString(@Nullable fina if ("pspdfkit/text".equalsIgnoreCase(type)) { return EnumSet.of(AnnotationType.FREETEXT); } + if ("pspdfkit/stamp".equalsIgnoreCase(type)) { + return EnumSet.of(AnnotationType.STAMP); + } return EnumSet.noneOf(AnnotationType.class); } } From 8001ede7e3f47f3596600bd5edf03b0ab9831844 Mon Sep 17 00:00:00 2001 From: RadAzzouz Date: Tue, 5 Jan 2021 09:02:16 -0500 Subject: [PATCH 2/2] Fix stamps and polylines not being correctly detected on iOS --- ios/RCTPSPDFKit/Converters/RCTConvert+PSPDFAnnotation.m | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ios/RCTPSPDFKit/Converters/RCTConvert+PSPDFAnnotation.m b/ios/RCTPSPDFKit/Converters/RCTConvert+PSPDFAnnotation.m index 511a3cd9..7471365f 100644 --- a/ios/RCTPSPDFKit/Converters/RCTConvert+PSPDFAnnotation.m +++ b/ios/RCTPSPDFKit/Converters/RCTConvert+PSPDFAnnotation.m @@ -54,10 +54,14 @@ + (PSPDFAnnotationType)annotationTypeFromInstantJSONType:(NSString *)type { return PSPDFAnnotationTypeLine; } else if ([type isEqualToString:@"pspdfkit/shape/polygon"]) { return PSPDFAnnotationTypePolygon; + } else if ([type isEqualToString:@"pspdfkit/shape/polyline"]) { + return PSPDFAnnotationTypePolyLine; } else if ([type isEqualToString:@"pspdfkit/shape/rectangle"]) { return PSPDFAnnotationTypeSquare; } else if ([type isEqualToString:@"pspdfkit/text"]) { return PSPDFAnnotationTypeFreeText; + } else if ([type isEqualToString:@"pspdfkit/stamp"]) { + return PSPDFAnnotationTypeStamp; } else { return PSPDFAnnotationTypeUndefined; }