Move redirect logic to the entry file

[frandiox]

Instead of calling notFoundMaybeRedirect, this changes it to throw 404 responses in the routes and then redirect conditionally in server.ts.

Some things to consider:

• I've renamed the function to storefrontRedirect. Open to other names 🙏
• We check the SFAPI for every 404.
• We need to relay the existing 404 response when not finding redirects to reuse the NotFound template that Remix has already rendered (otherwise we create an empty 404 response without HTML).
• Even if there is a network error while fetching the redirects, we don't throw and instead just return the existing 404 response.

Questions:

• Should we move the redirect logic to the app and remove it from Hydrogen? Or we keep it in the package?

🎩 :

• /collections/hydrogen should redirect to /collections/backcountry.
• /collections/xyz should show a 404 page.
• /collections/xyz?return_to=/about and /collections/xyz?redirect=/about should redirect accordingly.
• /collections/xyz?return_to=https%3A%2F%2Fgoogle.com should show a 404 page and warn in the terminal about cross-domain redirects.

[frehner]

Maybe things have changed, but the last time I talked with @blittle the idea was to remove all the redirect stuff out of each route file and only put it into server.ts?

[edit] whoops I think I misread something, that's what it appears you're doing. Excellent. 👍

[frehner]

In general we should probably never make our own Storefront API types - you can get this type by doing:

import type {UrlRedirectConnection} from '@shopify/hydrogen-react/storefront-api-types';

[frandiox]

I did that at the beginning and then reverted it to the original hardcoded version because I thought @shopify/hydrogen didn't depend on @shopify/hydrogen-react. Turns out it has it as a peer dependency so I will change it again 😅

[blittle]

Looks good after that query issue is fixed. Thx Fran!