Conversation
This comment has been minimized.
This comment has been minimized.
649b3dd to
e02d654
Compare
ba7ebfa to
6ebc816
Compare
e02d654 to
0079407
Compare
7943fa2 to
75b1445
Compare
frandiox
left a comment
There was a problem hiding this comment.
Looking good! I've left a few comments 👍
| "@remix-run/react": "1.12.0", | ||
| "@shopify/cli-kit": "3.29.0", | ||
| "@shopify/mini-oxygen": "^1.3.1", | ||
| "fast-glob": "^3.2.12", | ||
| "@shopify/remix-oxygen": "^1.0.0-alpha.3", | ||
| "@shopify/storefront-kit-react": "^2023.1.3", |
There was a problem hiding this comment.
These might be better as devDependencies + peerDependencies. The user will have them installed for the main app, right?
| @@ -0,0 +1,16 @@ | |||
| import {Links, Meta} from '@remix-run/react'; | |||
There was a problem hiding this comment.
There have been changes in the virtual routes, this file is not needed anymore. There's a virtual-root.tsx now that adds the HTML where you can also add error boundaries etc. I think you should get it if you merge the branch 2023-01.
There was a problem hiding this comment.
Whoops, forgot to do a last push!
| <h2>Welcome to Hydrogen & Remix!</h2> | ||
| <p> | ||
| Create your first route in <code>routes/index.jsx</code> | ||
| </p> |
There was a problem hiding this comment.
Since we are removing routes/index.jsx from the template, shouldn't we mention after updating .env that they also need to create the routes directory and the index.jsx file? cc @benjaminsehl
344e57d to
33f4c8d
Compare
benjaminsehl
left a comment
There was a problem hiding this comment.
Following up from Slack, let's keep an empty /routes directory set up so it's obvious where to add your route.
Let's also tweak the instructions to include the following:
You're seeing this because you have not yet configured your storefront token. To get started, edit
.env. Then, create your first route with the file/app/routes/index.js.
Learn more about connecting a storefront.
Or something like that. Would love to get this in for launch!
@frandiox @cartogram … wonder if we should potentially include a super basic route scaffolding command that does the skeleton for the homepage? shopify hydrogen generate route home.
You guys think that might be feasible?
@benjaminsehl Added in #442. Did you want to add anything to the |
Since we can't have empty directories in Git, we need to add a dummy |
|
Discussed with @benjaminsehl on dropping the |
c3f559d to
d52dcc5
Compare

Creates onboarding route
Not in scope for this PR
On template creation it shows:

Once store setup works with no errors:

Update:
Removed Cart from and index route. Reduced styling.