Skip to content

Onboarding shadow route#414

Merged
lordofthecactus merged 12 commits into2023-01from
feat/onboarding-page-shadow
Feb 6, 2023
Merged

Onboarding shadow route#414
lordofthecactus merged 12 commits into2023-01from
feat/onboarding-page-shadow

Conversation

@lordofthecactus
Copy link
Copy Markdown
Contributor

@lordofthecactus lordofthecactus commented Jan 31, 2023

Creates onboarding route

Not in scope for this PR

  • Mobile details
  • Special fonts
  • I have not put the links yet since docs are still pending.
  • Error page

On template creation it shows:
hydrogen browser screenshot before configured

Once store setup works with no errors:
hydrogen browser screenshot after configured

Update:

Removed Cart from and index route. Reduced styling.

@github-actions

This comment has been minimized.

Comment thread packages/cli/src/virtual-routes/routes/index.tsx
Copy link
Copy Markdown
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I've left a few comments 👍

Comment thread packages/cli/package.json Outdated
Comment on lines +29 to +34
"@remix-run/react": "1.12.0",
"@shopify/cli-kit": "3.29.0",
"@shopify/mini-oxygen": "^1.3.1",
"fast-glob": "^3.2.12",
"@shopify/remix-oxygen": "^1.0.0-alpha.3",
"@shopify/storefront-kit-react": "^2023.1.3",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These might be better as devDependencies + peerDependencies. The user will have them installed for the main app, right?

@@ -0,0 +1,16 @@
import {Links, Meta} from '@remix-run/react';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have been changes in the virtual routes, this file is not needed anymore. There's a virtual-root.tsx now that adds the HTML where you can also add error boundaries etc. I think you should get it if you merge the branch 2023-01.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, forgot to do a last push!

Comment on lines -4 to -7
<h2>Welcome to Hydrogen & Remix!</h2>
<p>
Create your first route in <code>routes/index.jsx</code>
</p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are removing routes/index.jsx from the template, shouldn't we mention after updating .env that they also need to create the routes directory and the index.jsx file? cc @benjaminsehl

@lordofthecactus
Copy link
Copy Markdown
Contributor Author

Error page
image

Copy link
Copy Markdown
Member

@benjaminsehl benjaminsehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up from Slack, let's keep an empty /routes directory set up so it's obvious where to add your route.

Let's also tweak the instructions to include the following:

You're seeing this because you have not yet configured your storefront token. To get started, edit .env. Then, create your first route with the file /app/routes/index.js.
Learn more about connecting a storefront.

Or something like that. Would love to get this in for launch!

@frandiox @cartogram … wonder if we should potentially include a super basic route scaffolding command that does the skeleton for the homepage? shopify hydrogen generate route home.

You guys think that might be feasible?

@cartogram
Copy link
Copy Markdown
Contributor

wonder if we should potentially include a super basic route scaffolding command that does the skeleton for the homepage? shopify hydrogen generate route home.

You guys think that might be feasible?

@benjaminsehl Added in #442. Did you want to add anything to the skeleton template that seeds the result of this command?

@frandiox
Copy link
Copy Markdown
Contributor

frandiox commented Feb 6, 2023

Following up from Slack, let's keep an empty /routes directory set up so it's obvious where to add your route.

Since we can't have empty directories in Git, we need to add a dummy .gitignore file but I think that makes Remix choke unless we add ignoredRouteFiles: ['**/.*'] to remix.config.js @lordofthecactus
Might land in #441

@lordofthecactus
Copy link
Copy Markdown
Contributor Author

Discussed with @benjaminsehl on dropping the route directory for now

Copy link
Copy Markdown
Member

@benjaminsehl benjaminsehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🚢🚢

@lordofthecactus lordofthecactus merged commit 9e87098 into 2023-01 Feb 6, 2023
@lordofthecactus lordofthecactus deleted the feat/onboarding-page-shadow branch February 6, 2023 22:41
@github-actions github-actions Bot mentioned this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants