Crash due to unhandled exceptions below FooAdapter::Connect

[sentry]

Sentry Issue: BINARYNINJA-2P

STATUS_FATAL_APP_EXIT / 0x7ff7c5043f86: Fatal Error: STATUS_FATAL_APP_EXIT / 0x7ff7c5043f86
  File "crashpad_client_win.cc", line 230, in crashpad::`anonymous namespace'::HandleAbortSignal
  File "throw.cpp", line 79, in _CxxThrowException
  File "rspconnector.cpp", line 421, in BinaryNinjaDebugger::RspConnector::GetXml
  File "corelliumadapter.cpp", line 89, in BinaryNinjaDebugger::CorelliumAdapter::LoadRegisterInfo
  File "corelliumadapter.cpp", line 234, in BinaryNinjaDebugger::CorelliumAdapter::Connect
...
(20 additional frame(s) were not displayed)

@bdash says:

CorelliumAdapter::LoadRegisterInfo calls RspConnector::GetXml, which can throw a std::runtime_error if it reads zero length data or if the data contains unexpected values. Nothing in CorelliumAdapter::LoadRegisterInfo or its call stack catches this exception, resulting in an abort due to the unhandled exception.

Similarly, GdbAdapter::Connect calls RspConnector::TransmitAndReceive which calls RspConnector::ExpectAck. If something other than an ack is received, it throws an std::runtime_error which is similarly unhandled.