From 45d0c1c9ed83c8c8179a8fb056162f48c6a5b92a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=85=85?= Date: Thu, 23 Nov 2023 08:20:29 +0800 Subject: [PATCH 01/15] chore: add toString in jobstatus --- .../org/apache/hugegraph/computer/driver/JobStatus.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java index 8131ff989..28c9b1094 100644 --- a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java +++ b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java @@ -18,6 +18,7 @@ package org.apache.hugegraph.computer.driver; import java.util.Objects; +import java.util.StringJoiner; public enum JobStatus { @@ -36,4 +37,9 @@ public static boolean finished(String status) { Objects.equals(status, FAILED.name()) || Objects.equals(status, SUCCEEDED.name()); } + + @Override + public String toString() { + return this.name(); + } } From f41d29e79dcb008f74f7d4e7def0e1c490bbfda6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=85=85?= Date: Thu, 23 Nov 2023 16:42:09 +0800 Subject: [PATCH 02/15] chore: remove unused job status --- .../java/org/apache/hugegraph/computer/driver/JobStatus.java | 1 - 1 file changed, 1 deletion(-) diff --git a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java index 28c9b1094..97b2230b6 100644 --- a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java +++ b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java @@ -18,7 +18,6 @@ package org.apache.hugegraph.computer.driver; import java.util.Objects; -import java.util.StringJoiner; public enum JobStatus { From 94a6779b50d33cbafddf11e4ab0cbb0ce689627e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=85=85?= Date: Fri, 24 Nov 2023 09:08:10 +0800 Subject: [PATCH 03/15] chore: remove job status toString and add default job state toString --- .../hugegraph/computer/driver/DefaultJobState.java | 11 +++++++++++ .../apache/hugegraph/computer/driver/JobStatus.java | 4 ---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java index f0f0002e5..c5a4c209f 100644 --- a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java +++ b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java @@ -18,6 +18,7 @@ package org.apache.hugegraph.computer.driver; import java.util.Objects; +import java.util.StringJoiner; public class DefaultJobState implements JobState { @@ -87,4 +88,14 @@ public int hashCode() { return Objects.hash(this.superstep, this.maxSuperstep, this.lastSuperstepStat, this.jobStatus); } + + @Override + public String toString() { + return new StringJoiner(", ", DefaultJobState.class.getSimpleName() + "[", "]") + .add("superstep=" + superstep) + .add("maxSuperstep=" + maxSuperstep) + .add("lastSuperstepStat=" + lastSuperstepStat) + .add("jobStatus=" + jobStatus) + .toString(); + } } diff --git a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java index 97b2230b6..48c28ac16 100644 --- a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java +++ b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java @@ -37,8 +37,4 @@ public static boolean finished(String status) { Objects.equals(status, SUCCEEDED.name()); } - @Override - public String toString() { - return this.name(); - } } From e2c78fcaab94c5addb91eaa01e168eb446e4ca6f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=85=85?= Date: Fri, 24 Nov 2023 10:05:00 +0800 Subject: [PATCH 04/15] chore: sleep more time --- .../java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java b/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java index 8b630ba8a..8f9db6b90 100644 --- a/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java +++ b/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java @@ -249,7 +249,7 @@ public void testJobCancelled() { this.driver.cancelJob(jobId, params); - UnitTestBase.sleep(1500L); + UnitTestBase.sleep(10000L); DefaultJobState jobState2 = new DefaultJobState(); jobState2.jobStatus(JobStatus.CANCELLED); From ac99735c93f4655d787edc7cd9f53c6be23e43cf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=85=85?= Date: Fri, 24 Nov 2023 11:13:10 +0800 Subject: [PATCH 05/15] chore: sleep more time --- .../java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java b/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java index 8f9db6b90..d6cf85ed0 100644 --- a/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java +++ b/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java @@ -249,7 +249,7 @@ public void testJobCancelled() { this.driver.cancelJob(jobId, params); - UnitTestBase.sleep(10000L); + UnitTestBase.sleep(90000L); DefaultJobState jobState2 = new DefaultJobState(); jobState2.jobStatus(JobStatus.CANCELLED); From 08a387ac4f8b7f6bdf1313d3670f4aad592ac802 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=85=85?= Date: Fri, 24 Nov 2023 11:30:47 +0800 Subject: [PATCH 06/15] chore: observe running then cancel --- .../java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java b/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java index d6cf85ed0..4a3caff77 100644 --- a/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java +++ b/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java @@ -243,13 +243,13 @@ public void testJobCancelled() { jobObserver); DefaultJobState jobState = new DefaultJobState(); - jobState.jobStatus(JobStatus.INITIALIZING); + jobState.jobStatus(JobStatus.RUNNING); Mockito.verify(jobObserver, Mockito.timeout(15000L).atLeast(1)) .onJobStateChanged(Mockito.eq(jobState)); this.driver.cancelJob(jobId, params); - UnitTestBase.sleep(90000L); + UnitTestBase.sleep(1500L); DefaultJobState jobState2 = new DefaultJobState(); jobState2.jobStatus(JobStatus.CANCELLED); From 1cc346fc06b417b2f3637ea8b41ae95f8940e669 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=85=85?= Date: Mon, 27 Nov 2023 15:19:03 +0800 Subject: [PATCH 07/15] debug: delete using foreground --- .../apache/hugegraph/computer/k8s/driver/KubernetesDriver.java | 3 ++- .../java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/computer-k8s/src/main/java/org/apache/hugegraph/computer/k8s/driver/KubernetesDriver.java b/computer-k8s/src/main/java/org/apache/hugegraph/computer/k8s/driver/KubernetesDriver.java index a1e6bb2a1..1cbbe7d43 100644 --- a/computer-k8s/src/main/java/org/apache/hugegraph/computer/k8s/driver/KubernetesDriver.java +++ b/computer-k8s/src/main/java/org/apache/hugegraph/computer/k8s/driver/KubernetesDriver.java @@ -39,6 +39,7 @@ import java.util.concurrent.CompletableFuture; import java.util.concurrent.ConcurrentHashMap; +import io.fabric8.kubernetes.api.model.DeletionPropagation; import org.apache.commons.collections.CollectionUtils; import org.apache.commons.io.FileUtils; import org.apache.commons.lang3.StringUtils; @@ -282,7 +283,7 @@ private void checkComputerConf(Map computerConf, @Override public boolean cancelJob(String jobId, Map params) { - return this.operation.withName(KubeUtil.crName(jobId)).delete(); + return this.operation.withName(KubeUtil.crName(jobId)).withPropagationPolicy(DeletionPropagation.FOREGROUND).delete(); } @Override diff --git a/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java b/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java index 4a3caff77..8b630ba8a 100644 --- a/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java +++ b/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java @@ -243,7 +243,7 @@ public void testJobCancelled() { jobObserver); DefaultJobState jobState = new DefaultJobState(); - jobState.jobStatus(JobStatus.RUNNING); + jobState.jobStatus(JobStatus.INITIALIZING); Mockito.verify(jobObserver, Mockito.timeout(15000L).atLeast(1)) .onJobStateChanged(Mockito.eq(jobState)); From f6e850ba299ec782208dca22aa0d9c4308edf768 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=85=85?= Date: Mon, 27 Nov 2023 15:27:54 +0800 Subject: [PATCH 08/15] chore: delete --- .../hugegraph/computer/k8s/driver/KubernetesDriver.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/computer-k8s/src/main/java/org/apache/hugegraph/computer/k8s/driver/KubernetesDriver.java b/computer-k8s/src/main/java/org/apache/hugegraph/computer/k8s/driver/KubernetesDriver.java index 1cbbe7d43..c1a8f7162 100644 --- a/computer-k8s/src/main/java/org/apache/hugegraph/computer/k8s/driver/KubernetesDriver.java +++ b/computer-k8s/src/main/java/org/apache/hugegraph/computer/k8s/driver/KubernetesDriver.java @@ -283,7 +283,9 @@ private void checkComputerConf(Map computerConf, @Override public boolean cancelJob(String jobId, Map params) { - return this.operation.withName(KubeUtil.crName(jobId)).withPropagationPolicy(DeletionPropagation.FOREGROUND).delete(); + return this.operation.withName(KubeUtil.crName(jobId)) + .withPropagationPolicy(DeletionPropagation.FOREGROUND) + .delete(); } @Override From 55b21564e349db6909f6a2122427d8b5412d57a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=85=85?= Date: Mon, 27 Nov 2023 15:46:44 +0800 Subject: [PATCH 09/15] chore: delete empty space --- .../java/org/apache/hugegraph/computer/driver/JobStatus.java | 1 - 1 file changed, 1 deletion(-) diff --git a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java index 48c28ac16..8131ff989 100644 --- a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java +++ b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/JobStatus.java @@ -36,5 +36,4 @@ public static boolean finished(String status) { Objects.equals(status, FAILED.name()) || Objects.equals(status, SUCCEEDED.name()); } - } From 5de0a11603105095343bc77fe07d4361d85af1dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=85=85?= Date: Mon, 27 Nov 2023 18:29:09 +0800 Subject: [PATCH 10/15] style: make maintainer happy --- .../hugegraph/computer/driver/DefaultJobState.java | 13 +++++++------ .../computer/k8s/driver/KubernetesDriver.java | 4 ++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java index c5a4c209f..c2b0bf9ec 100644 --- a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java +++ b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java @@ -91,11 +91,12 @@ public int hashCode() { @Override public String toString() { - return new StringJoiner(", ", DefaultJobState.class.getSimpleName() + "[", "]") - .add("superstep=" + superstep) - .add("maxSuperstep=" + maxSuperstep) - .add("lastSuperstepStat=" + lastSuperstepStat) - .add("jobStatus=" + jobStatus) - .toString(); + return String.format("%s[super=%s, maxSuperStep=%s, lastSuperstepStat=%s, jobStatus=%s]", + DefaultJobState.class.getSimpleName(), + superstep, + maxSuperstep, + lastSuperstepStat, + jobStatus + ); } } diff --git a/computer-k8s/src/main/java/org/apache/hugegraph/computer/k8s/driver/KubernetesDriver.java b/computer-k8s/src/main/java/org/apache/hugegraph/computer/k8s/driver/KubernetesDriver.java index c1a8f7162..a6e845b65 100644 --- a/computer-k8s/src/main/java/org/apache/hugegraph/computer/k8s/driver/KubernetesDriver.java +++ b/computer-k8s/src/main/java/org/apache/hugegraph/computer/k8s/driver/KubernetesDriver.java @@ -284,8 +284,8 @@ private void checkComputerConf(Map computerConf, @Override public boolean cancelJob(String jobId, Map params) { return this.operation.withName(KubeUtil.crName(jobId)) - .withPropagationPolicy(DeletionPropagation.FOREGROUND) - .delete(); + .withPropagationPolicy(DeletionPropagation.FOREGROUND) + .delete(); } @Override From 11af3707d735f9233aa45a33aeefd2b745b788bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=85=85?= Date: Mon, 27 Nov 2023 18:30:04 +0800 Subject: [PATCH 11/15] style: make maintainer happy --- .../org/apache/hugegraph/computer/driver/DefaultJobState.java | 1 - 1 file changed, 1 deletion(-) diff --git a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java index c2b0bf9ec..96d177a40 100644 --- a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java +++ b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java @@ -18,7 +18,6 @@ package org.apache.hugegraph.computer.driver; import java.util.Objects; -import java.util.StringJoiner; public class DefaultJobState implements JobState { From 7977b42176a715e59e9f8e45b12e3c374e9cab67 Mon Sep 17 00:00:00 2001 From: imbajin Date: Tue, 28 Nov 2023 11:34:51 +0800 Subject: [PATCH 12/15] Update DefaultJobState.java --- .../apache/hugegraph/computer/driver/DefaultJobState.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java index 96d177a40..07c33a0ac 100644 --- a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java +++ b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java @@ -91,11 +91,7 @@ public int hashCode() { @Override public String toString() { return String.format("%s[super=%s, maxSuperStep=%s, lastSuperstepStat=%s, jobStatus=%s]", - DefaultJobState.class.getSimpleName(), - superstep, - maxSuperstep, - lastSuperstepStat, - jobStatus - ); + DefaultJobState.class.getSimpleName(), superstep, maxSuperstep, + lastSuperstepStat, jobStatus); } } From 2b6c422aed951c46682836d61af3c5c023cc5e16 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=96=87=E5=85=85?= Date: Mon, 4 Dec 2023 17:47:44 +0800 Subject: [PATCH 13/15] chore: change toString to superstep --- .../org/apache/hugegraph/computer/driver/DefaultJobState.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java index 07c33a0ac..7c92d83e4 100644 --- a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java +++ b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java @@ -90,7 +90,7 @@ public int hashCode() { @Override public String toString() { - return String.format("%s[super=%s, maxSuperStep=%s, lastSuperstepStat=%s, jobStatus=%s]", + return String.format("%s[superstep=%s, maxSuperStep=%s, lastSuperstepStat=%s, jobStatus=%s]", DefaultJobState.class.getSimpleName(), superstep, maxSuperstep, lastSuperstepStat, jobStatus); } From 9b008b7c6444a456fc486c03e65bddb852a06a5c Mon Sep 17 00:00:00 2001 From: imbajin Date: Mon, 4 Dec 2023 19:03:33 +0800 Subject: [PATCH 14/15] Update DefaultJobState.java --- .../apache/hugegraph/computer/driver/DefaultJobState.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java index 7c92d83e4..bda3fe15a 100644 --- a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java +++ b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java @@ -90,8 +90,8 @@ public int hashCode() { @Override public String toString() { - return String.format("%s[superstep=%s, maxSuperStep=%s, lastSuperstepStat=%s, jobStatus=%s]", - DefaultJobState.class.getSimpleName(), superstep, maxSuperstep, - lastSuperstepStat, jobStatus); + return String.format("%s[superstep=%s, maxSuperStep=%s, lastSuperstepStat=%s, + jobStatus=%s]", DefaultJobState.class.getSimpleName(), + superstep, maxSuperstep, lastSuperstepStat, jobStatus); } } From 1133673fd66aacde6902fc92516bc1e98490feba Mon Sep 17 00:00:00 2001 From: imbajin Date: Mon, 4 Dec 2023 19:27:05 +0800 Subject: [PATCH 15/15] Update DefaultJobState.java --- .../computer/driver/DefaultJobState.java | 56 +++++++++++++++++-- 1 file changed, 52 insertions(+), 4 deletions(-) diff --git a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java index bda3fe15a..0ae4ba6bb 100644 --- a/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java +++ b/computer-driver/src/main/java/org/apache/hugegraph/computer/driver/DefaultJobState.java @@ -19,6 +19,11 @@ import java.util.Objects; +/** + * DefaultJobState is an implementation of the JobState interface. + * It holds the state of a job including the current superstep, + * the maximum superstep, the last superstep statistics, and the job status. + */ public class DefaultJobState implements JobState { private int superstep; @@ -26,46 +31,83 @@ public class DefaultJobState implements JobState { private SuperstepStat lastSuperstepStat; private JobStatus jobStatus; + /** + * Sets the current superstep. + * @param superstep The current superstep. + * @return The updated DefaultJobState instance. + */ public DefaultJobState superstep(int superstep) { this.superstep = superstep; return this; } + /** + * Sets the maximum superstep. + * @param maxSuperstep The maximum superstep. + * @return The updated DefaultJobState instance. + */ public DefaultJobState maxSuperstep(int maxSuperstep) { this.maxSuperstep = maxSuperstep; return this; } + /** + * Sets the last superstep statistics. + * @param lastSuperstepStat The last superstep statistics. + * @return The updated DefaultJobState instance. + */ public DefaultJobState lastSuperstepStat(SuperstepStat lastSuperstepStat) { this.lastSuperstepStat = lastSuperstepStat; return this; } + /** + * Sets the job status. + * @param jobStatus The job status. + * @return The updated DefaultJobState instance. + */ public DefaultJobState jobStatus(JobStatus jobStatus) { this.jobStatus = jobStatus; return this; } + /** + * @return The current superstep. + */ @Override public int superstep() { return this.superstep; } + /** + * @return The maximum superstep. + */ @Override public int maxSuperstep() { return this.maxSuperstep; } + /** + * @return The last superstep statistics. + */ @Override public SuperstepStat lastSuperstepStat() { return this.lastSuperstepStat; } + /** + * @return The job status. + */ @Override public JobStatus jobStatus() { return this.jobStatus; } + /** + * Checks if the given object is equal to this instance. + * @param o The object to compare with. + * @return true if the given object is equal to this instance, false otherwise. + */ @Override public boolean equals(Object o) { if (this == o) { @@ -74,24 +116,30 @@ public boolean equals(Object o) { if (!(o instanceof DefaultJobState)) { return false; } + DefaultJobState jobState = (DefaultJobState) o; return this.superstep == jobState.superstep && this.maxSuperstep == jobState.maxSuperstep && - Objects.equals(this.lastSuperstepStat, - jobState.lastSuperstepStat) && + Objects.equals(this.lastSuperstepStat, jobState.lastSuperstepStat) && this.jobStatus == jobState.jobStatus; } + /** + * @return The hash code of this instance. + */ @Override public int hashCode() { return Objects.hash(this.superstep, this.maxSuperstep, this.lastSuperstepStat, this.jobStatus); } + /** + * @return A string representation of this instance. + */ @Override public String toString() { - return String.format("%s[superstep=%s, maxSuperStep=%s, lastSuperstepStat=%s, - jobStatus=%s]", DefaultJobState.class.getSimpleName(), + return String.format("%s[superstep=%s, maxSuperStep=%s, lastSuperstepStat=%s, " + + "jobStatus=%s]", DefaultJobState.class.getSimpleName(), superstep, maxSuperstep, lastSuperstepStat, jobStatus); } }