Map-read uses unimported symbol resulting in ReferenceError

[attila-kun]

Thank you for this amazing project!
Ran into a bug today:

Example

This bug needs at least 2 files to exist:
src/types.go

type Foo struct {
	Value string
}

var Storage = map[string]Foo{
	"foo": {Value: "bar"},
}

src/read.go

func ReadValue(key string) string {
	return Storage[key].Value
}

Expected behavior

The generated code should be runnable, and this call:

console.log(ReadValue("foo"));

should print:

bar

Actual behaviour

A plain Go map read:

func ReadValue(key string) string {
	return Storage[key].Value
}

is compiled into TypeScript that calls mapGet with new Foo() as the zero-value fallback:

export function ReadValue(key: string): string {
	return $.mapGet(Storage, key, new Foo())[0].Value
}

However, the generated file does not import Foo, so the code crashes at runtime with:

ReferenceError: Foo is not defined

I've prepared the same example here: https://github.com/attila-kun/goscriptbug

[paralin]

Thanks for the report and the repro. Are you able to make a repro as a unit test in compliance/tests and submit a PR with it?

[attila-kun]

@paralin Yep, working on that.

[attila-kun]

@paralin : Raised #135 which contains the failing scenario only.

Created a separate diff for a possible fix but I vibe coded it and didn't have the capacity to properly understand it yet, so treat it with a grain of salt: https://github.com/attila-kun/goscript/pull/1/changes#diff-a6196653661a45d23baf4147d63ddfd85f18bf44cd60ae36e98379b940e77d3a
Compliance tests are passing on the branch.