Skip to content

rk3528-nanopi-zero2: verify snps,reset-gpios vs snps,reset-gpio property name in Ethernet PHY reset #9619

@coderabbitai

Description

@coderabbitai

Follow-up from PR #9618

This issue was created as a follow-up to a review comment in PR #9618 by @EvilOlaf that was deemed out of scope for that PR.

File: patch/kernel/archive/rockchip64-7.0/rk3528-14-arm64-dts-rockchip-nanopi-zero2-fix-ethernet-phy-reset.patch

Concern: The patch uses the plural form snps,reset-gpios as the property name in the &gmac1 device-tree node, while all other Ethernet controllers in the rockchip64-7.0 patch set use the singular form snps,reset-gpio. The plural form may not be recognized by the DT binding parser.

Proposed fix:

-	snps,reset-gpios = <&gpio4 RK_PC2 GPIO_ACTIVE_LOW>;
+	snps,reset-gpio = <&gpio4 RK_PC2 GPIO_ACTIVE_LOW>;
 	snps,reset-delays-us = <0 20000 100000>;

Please verify which form is correct per the upstream stmmac/GMAC DT binding documentation and update the patch accordingly.

References:

/cc @rubycomm @EvilOlaf

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions