fix: improved server side cleanup after ingest#477
Merged
NicolasIRAGNE merged 1 commit intomainfrom Jul 30, 2025
Merged
Conversation
|
⚙️ Preview environment was undeployed. |
Contributor
|
lgtm, I think this is not ideal in case of local (eg. dev) non-S3 environments but I don't have a better solution that is cheap to implement so we can go that route now |
NicolasIRAGNE
approved these changes
Jul 30, 2025
57aea9b to
bbdc938
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor repository cleanup from background task to immediate cleanup
Overview
This PR refactors the repository cleanup mechanism from a background cleanup task to immediate cleanup after each processing operation, improving resource management and simplifying the codebase.
Changes Made
🧹 Cleanup Strategy Change
🔧 Key Modifications
src/server/main.pylifespanimport and usage from FastAPI app initializationsrc/server/query_processor.py_cleanup_repository()function for immediate cleanupprocess_query():shutil.rmtree()with proper error handling and loggingsrc/server/server_utils.pylifespan()context manager_remove_old_repositories()background task_process_folder()helper function_append_line()utility functionasyncio,shutil,time,contextlib,pathlib)src/server/server_config.pyDELETE_REPO_AFTERconstant (no longer needed)