Skip to content

README.md: use brew instead of brew cask for handbrakecli#106

Merged
lisamelton merged 1 commit intolisamelton:masterfrom
vitorgalvao:patch-1
Dec 26, 2016
Merged

README.md: use brew instead of brew cask for handbrakecli#106
lisamelton merged 1 commit intolisamelton:masterfrom
vitorgalvao:patch-1

Conversation

@vitorgalvao
Copy link
Copy Markdown
Contributor

This should not be merged yet, but I’m submitting now in case you want to take a look or prepare something that needs preparing.

We’re moving HandbrakeCLI from homebrew-cask to homebrew. See PR removing from HBC and PR adding to HB.

Still not certain on the name, it could be handbrakecli (I’ll update the PR if that’s the case).

You seem to have dependencies in alphabetical order, but since HandbrakeCLI is the most important one, it makes sense to have it at the top. If you want it any other way just let me know and I’ll change it. Or feel free to edit it yourself if you want, I’ve left “Allow edits from maintainers” checked.

Happy holidays!

@timsutton
Copy link
Copy Markdown
Contributor

LOL - was just preparing a similar PR when I noticed the discussion about this move. This just went live a on Homebrew core a few minutes ago, and it can be done via brew install handbrake.

@lisamelton
Copy link
Copy Markdown
Owner

@vitorgalvao @timsutton Thanks for the patch! I may take this or make a similar change soon, even before my next update/bug fix, but I'll likely wait until after Christmas. It's a little busy around here today. :)

@vitorgalvao
Copy link
Copy Markdown
Contributor Author

@donmelton As @timsutton mentioned, this is already live, so as of now brew cask install handbrakecli will not work, but brew install handbrake will. This does not break existing installs, so there is absolutely no rush. Everything will keep working just fine.

The name was kept as in this PR, so it can be merged as is.

Happy holidays to you both!

@lisamelton lisamelton merged commit 8d052a3 into lisamelton:master Dec 26, 2016
@lisamelton
Copy link
Copy Markdown
Owner

@vitorgalvao OK, it's merged and thanks again for the patch!

BTW, I tweaked your wording after the merge but not by much.

@vitorgalvao vitorgalvao deleted the patch-1 branch December 26, 2016 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants