Remove section about x265 version in Handbrake#118
Closed
samhutchins wants to merge 1 commit intolisamelton:masterfrom
samhutchins:h265-faq
Closed
Remove section about x265 version in Handbrake#118samhutchins wants to merge 1 commit intolisamelton:masterfrom samhutchins:h265-faq
samhutchins wants to merge 1 commit intolisamelton:masterfrom
samhutchins:h265-faq
Conversation
As of Handbrake 1.0.0 this paragraph is no longer needed
Owner
|
@samhutchins Thanks for the patch! You're right that this section of the "FAQ" should change but that's the wrong wording. You can't delete that entire paragraph or the next paragraph doesn't make sense. I won't take your patch but I will fix this. Thanks for bringing it to my attention! |
Owner
|
@samhutchins Here's how I might re-word that paragraph:
... which would leave the next paragraph unchanged. |
Owner
|
@samhutchins OK, I checked in that re-worded change. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Handbrake 1.0.0 this paragraph is no longer needed