Skip to content

Remove section about x265 version in Handbrake#118

Closed
samhutchins wants to merge 1 commit intolisamelton:masterfrom
samhutchins:h265-faq
Closed

Remove section about x265 version in Handbrake#118
samhutchins wants to merge 1 commit intolisamelton:masterfrom
samhutchins:h265-faq

Conversation

@samhutchins
Copy link
Copy Markdown
Contributor

As of Handbrake 1.0.0 this paragraph is no longer needed

As of Handbrake 1.0.0 this paragraph is no longer needed
@lisamelton
Copy link
Copy Markdown
Owner

@samhutchins Thanks for the patch! You're right that this section of the "FAQ" should change but that's the wrong wording. You can't delete that entire paragraph or the next paragraph doesn't make sense.

I won't take your patch but I will fix this. Thanks for bringing it to my attention!

@lisamelton lisamelton closed this Jan 18, 2017
@lisamelton
Copy link
Copy Markdown
Owner

@samhutchins Here's how I might re-word that paragraph:

My ratecontrol system couldn't be applied with the x265 encoder in older versions of HandBrake because it didn't allow access to qpmax, critical for maintaining quality in certain situations. The latest version of HandBrake includes a new encoder which fixes that.

... which would leave the next paragraph unchanged.

@lisamelton
Copy link
Copy Markdown
Owner

@samhutchins OK, I checked in that re-worded change. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants