Skip to content

Fix potential issue in TLS Server that could be exploited to use TLS Session Resumption to bypass trust check after trust has been removed #71

@sthelen-enqs

Description

@sthelen-enqs

Lint:

Check failure on line R64
Check failure:
G123: tls.Config uses VerifyPeerCertificate while session resumption may remain enabled and VerifyConnection is not set; resumed sessions can bypass custom certificate checks

According to the SHIP 1.1.0 Specification:

To allow fast reconnections over TLS without the need for a full TLS handshake, session
resumption SHOULD be supported. This means that the session state holding the master secret and a
session id SHOULD be stored and reused during reconnections.

Therefore we should either:

  1. Ensure that resumed sessions are checked against the current trust store
  2. Clear or remove expired entries from the TLS session resumption state when removing items from the trust store
  3. If neither options 1 nor 2 look reasonable, disable TLS session resumption as support is optional and not required

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions