make encode method to accept array of integers#24
Merged
jd327 merged 1 commit intovinkla:masterfrom Oct 22, 2014
leunggamciu:leunggamciu
Merged
make encode method to accept array of integers#24jd327 merged 1 commit intovinkla:masterfrom leunggamciu:leunggamciu
jd327 merged 1 commit intovinkla:masterfrom
leunggamciu:leunggamciu
Conversation
Collaborator
|
Hi @leunggamciu, haven't forgotten about your PR, just been traveling. Need some time to review. |
jd327
pushed a commit
that referenced
this pull request
Oct 22, 2014
make encode method to accept array of integers
Collaborator
|
Initially, I've asked senior programmers on best practices - whether to allow accepting several types of input here or not, and the response was usually to stick to one. However, as time goes by I'm starting to see there's many use cases and some ways are easier than others, so in practice it might be better to support both ways. Thanks for the pull request. |
Contributor
Author
|
My pleasure!:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello, ivanakimov
This PR is try to make
encodemethod to accept a group of integers, instead of passing it one by one. I hope it is helpful.