fix: only parse commit messages during git node backport analysis#651
Merged
aduh95 merged 1 commit intonodejs:mainfrom Oct 12, 2022
Merged
fix: only parse commit messages during git node backport analysis#651aduh95 merged 1 commit intonodejs:mainfrom
aduh95 merged 1 commit intonodejs:mainfrom
Conversation
Previously we parse the entire commit, including the diff, which can result in ENOBUFS errors. Adding `-s` option to the `git show` command would eliminate the commit body in the output, which we don't need, so the error can be less likely to happen during commit message analysis.
Codecov ReportBase: 84.03% // Head: 84.03% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
=======================================
Coverage 84.03% 84.03%
=======================================
Files 37 37
Lines 4077 4077
=======================================
Hits 3426 3426
Misses 651 651 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aduh95
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we parse the entire commit, including the diff, which can result in ENOBUFS errors. Adding
-soption to thegit showcommand would eliminate the commit body in the output, which we don't need, so the error can be less likely to happen during commit message analysis.