Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
- Coverage 83.41% 83.38% -0.04%
==========================================
Files 37 37
Lines 4131 4158 +27
==========================================
+ Hits 3446 3467 +21
- Misses 685 691 +6
☔ View full report in Codecov by Sentry. |
17a048b to
f045e77
Compare
7276a4e to
ca602be
Compare
Member
Author
|
@nodejs/releasers just updated this PR. Now it iterates over open PRs in the private repo and adds them to the proposal branch -- with the metadata. If the PR doesn't contain CVE-ID metadata, it will ask to include it in the middle of the process. Could you please review it? |
ca602be to
ad33378
Compare
ruyadorno
reviewed
Jul 11, 2023
Member
ruyadorno
left a comment
There was a problem hiding this comment.
LGTM! A few details you might want to clean up before shipping (although I might just need clarification in a few places) 👍
Great work! Security releases are going to be much simpler 😊 🙏
ad33378 to
baf8494
Compare
ruyadorno
approved these changes
Jul 13, 2023
Member
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm doing an experiment as part of my work on nodejs/security-wg#860 + upcoming security release.
I was talking with @BethGriggs and looks reasonable to generate the proposal PR for security releases using
git node release --security --prepare 19.6.1.Currently,
git node landdoesn't work for the private repo, so the workflow is:Example:
Limitations that should be addressed in subsequent PRs: