fix(v8): fix spawning of subprocesses#726
Merged
aduh95 merged 4 commits intonodejs:mainfrom Sep 12, 2023
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
=======================================
Coverage 83.38% 83.38%
=======================================
Files 37 37
Lines 4158 4158
=======================================
Hits 3467 3467
Misses 691 691 ☔ View full report in Codecov by Sentry. |
MoLow
approved these changes
Sep 11, 2023
Member
MoLow
left a comment
MoLow
left a comment
There was a problem hiding this comment.
LGTM, maybe we should add tests for these flows
targos
requested changes
Sep 11, 2023
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
Still not quite right:
- Output from git command appears in the terminal
- Error is still here
$ node /Users/mzasso/git/nodejs/node-core-utils/bin/git-node.js v8 --v8-dir ~/git/chromium/v8/v8 major
❯ Update local V8 clone
⠸ Fetch V8
❯ Update local V8 clone
❯ Update local V8 clone
⠴ Fetch V8
◼ Major V8 update
◼ Update V8 version in maintaining-dependencies.md
◼ Commit V8 update
◼ Update version numbers
From https://chromium.googlesource.com/v8/v8
* [new branch] 11.9.50 -> origin/11.9.50
* [new branch] 11.9.51 -> origin/11.9.51
+ bd2ab654247...eb941aa621b canary -> origin/canary (forced update)
4f2f8661fa4..5513eb17d41 lkgr -> origin/lkgr
85d36de7fb4..36d5e54d760 main -> origin/main
+ bd2ab654247...eb941aa621b roll -> origin/roll (forced update)
✔ Update local V8 clone
❯ Major V8 update
✔ Update local V8 clone
❯ Major V8 update
✔ Get current V8 version
⠙ Checkout V8 branch
◼ Remove deps/v8
◼ Clone branch to deps/v8
◼ Remove deps/v8/.git
◼ Track all files in deps/v8
◼ Update V8 DEPS
◼ Apply Node-specific changes
◼ Update V8 version in maintaining-dependencies.md
◼ Commit V8 update
◼ Update version numbers
error: branch '11.9.51' not found
Member
Certainly, but that's not easy to do (and V8 repo takes a very long time to clone). |
Member
|
It's better (doesn't fail anymore), but the Details |
targos
approved these changes
Sep 12, 2023
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
LGTM with my last commit. Git output is no longer intertwined with Listr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #722 (comment)
Fixes: #723