-
Notifications
You must be signed in to change notification settings - Fork 612
"cve_bin_tool.log.LOGGER is not a valid type" #2870
Copy link
Copy link
Labels
good first issueGood for newcomersGood for newcomers
Description
I've just merged a fix for some type errors in #2786 but one of the changes the contributor made was switching us from using our customized LOGGER to the built-in logger that it's based on.
I'd prefer a solution that fixed cve_bin_tool.log.LOGGER itself. You can find it in https://github.com/intel/cve-bin-tool/blob/main/cve_bin_tool/log.py -- basically it's just setting up the logger with some consistent arguments. I'm not sure what the right solution here is but if I had to guess it's the fact that LOGGER itself can be Null so you might need to explicitly set a type for LOGGER and make sure that it is not null.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers