This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Use strict version tags for the download urls#76
Merged
Conversation
refactor: rename vars and add comments in helpers/templates.ts fix #70
PaulRBerg
force-pushed
the
strictRefUrl
branch
from
5cd5377 to
0f84e0a
Compare
refactor: move download functions in new file github.ts refactor: rename template files constants refactor: turn 'isFolderEmpty.ts' into 'files.ts'
Contributor
Author
|
This fixes #70. |
Contributor
|
Looks good to me! |
TomAFrench
suggested changes
Oct 18, 2020
Contributor
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
Only these to get sorted out first.
PaulRBerg
force-pushed
the
strictRefUrl
branch
from
6d3060d to
fef0382
Compare
PaulRBerg
force-pushed
the
strictRefUrl
branch
from
4977152 to
bca4fd7
Compare
PaulRBerg
changed the title
pbbhopp
pushed a commit
to veloxoft/space-swap-front
that referenced
this pull request
Mar 29, 2021
* fix: Restored missing code * fix: Restored pool ordering * fix: Syrup pool ordering * feat: Updated pool card finished state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing your suggestions in #70 was easier than I suspected. GitHub uses refs to generate tarball archives, so I simply ditched the
branchconstant from the download url and replaced it with thepackage.json"version" field.CEA_ENVenvironment variable and, if it's "development", use the branch name in the download url. The branch name is either GITHUB_REF (stripped of "refs/heads/") in CI or a customCEA_GITHUB_REFin local development. An error is thrown if none of the latter can be found, butCEA_ENVis set to "development".