Sample weights for PiecewiseTreeRegressor

[jakebasilico]

I'm trying to build an ensemble learner using PiecewiseTreeRegressors. In doing so, the parameter "sample_weight" is utilized during fitting of the estimator. This throws an error here:

mlinsights/mlinsights/mlmodel/piecewise_tree_regression_criterion_linear.pyx

Line 150 in c23988e

sum = sample_weight.sum()

when executing line 136 in piecewise_tree_regression.py:

mlinsights/mlinsights/mlmodel/piecewise_tree_regression.py

Line 136 in c23988e

dec = LinearRegressorCriterion.create(xs, ys, ws)

AttributeError: 'mlinsights.mlmodel.piecewise_tree_regression_crite' object has no attribute 'sum'

[jakebasilico]

Also an error here when checking whether sample_weight is none:

mlinsights/mlinsights/mlmodel/piecewise_tree_regression.py

Line 135 in c23988e

ws = sample_weight[ind].copy() if sample_weight else None

Because sample_weight is an numpy array, it looks like using sample_weight.any() or "if sample_weight is not None" fixes this issue

[jakebasilico]

Loving the package so far!

[sdpython]

Sorry for the delay, is it possible to know how you call it? sample_weights should be an array.