Migrate to static data providers using rector/rector

OskarStark · nicolas-grekas · commit e366fab251e6 · 2023-02-14T09:03:56.000+01:00
diff --git a/Tests/Comparator/ComparatorTest.php b/Tests/Comparator/ComparatorTest.php
@@ -65,7 +65,7 @@ public function testTestSucceeds(string $operator, string $target, string $teste
         $this->assertTrue($c->test($testedValue));
     }
 
-    public function provideMatches(): array
+    public static function provideMatches(): array
     {
         return [
             ['<', '1000', '500'],
@@ -91,7 +91,7 @@ public function testTestFails(string $operator, string $target, string $testedVa
         $this->assertFalse($c->test($testedValue));
     }
 
-    public function provideNonMatches(): array
+    public static function provideNonMatches(): array
     {
         return [
             ['>', '1000', '500'],
diff --git a/Tests/Comparator/DateComparatorTest.php b/Tests/Comparator/DateComparatorTest.php
@@ -49,7 +49,7 @@ public function testTest($test, $match, $noMatch)
         }
     }
 
-    public function getTestData()
+    public static function getTestData()
     {
         return [
             ['< 2005-10-10', [strtotime('2005-10-09')], [strtotime('2005-10-15')]],
diff --git a/Tests/Comparator/NumberComparatorTest.php b/Tests/Comparator/NumberComparatorTest.php
@@ -51,7 +51,7 @@ public function testTest($test, $match, $noMatch)
         }
     }
 
-    public function getTestData()
+    public static function getTestData()
     {
         return [
             ['< 1000', ['500', '999'], ['1000', '1500']],
@@ -81,7 +81,7 @@ public function getTestData()
         ];
     }
 
-    public function getConstructorTestData()
+    public static function getConstructorTestData()
     {
         return [
             [
diff --git a/Tests/FinderTest.php b/Tests/FinderTest.php
@@ -1274,7 +1274,7 @@ public function testRegexSpecialCharsLocationWithPathRestrictionContainingStartF
         $this->assertIterator($this->toAbsoluteFixtures($expected), $finder);
     }
 
-    public function getContainsTestData()
+    public static function getContainsTestData()
     {
         return [
             ['', '', []],
@@ -1292,7 +1292,7 @@ public function getContainsTestData()
         ];
     }
 
-    public function getRegexNameTestData()
+    public static function getRegexNameTestData()
     {
         return [
             ['~.*t\\.p.+~i'],
@@ -1313,7 +1313,7 @@ public function testPath($matchPatterns, $noMatchPatterns, array $expected)
         $this->assertIterator($this->toAbsoluteFixtures($expected), $finder);
     }
 
-    public function getTestPathData()
+    public static function getTestPathData()
     {
         return [
             ['', '', []],
diff --git a/Tests/GitignoreTest.php b/Tests/GitignoreTest.php
@@ -392,7 +392,7 @@ public static function provider(): array
         return $cases;
     }
 
-    public function providerExtended(): array
+    public static function providerExtended(): array
     {
         $basicCases = self::provider();
 
@@ -479,7 +479,7 @@ public function testToRegexMatchingNegatedPatterns(array $gitignoreLines, array
         }
     }
 
-    public function provideNegatedPatternsCases(): iterable
+    public static function provideNegatedPatternsCases(): iterable
     {
         yield [
             [''],
diff --git a/Tests/Iterator/CustomFilterIteratorTest.php b/Tests/Iterator/CustomFilterIteratorTest.php
@@ -33,7 +33,7 @@ public function testAccept($filters, $expected)
         $this->assertIterator($expected, $iterator);
     }
 
-    public function getAcceptData()
+    public static function getAcceptData()
     {
         return [
             [[function (\SplFileInfo $fileinfo) { return false; }], []],
diff --git a/Tests/Iterator/DateRangeFilterIteratorTest.php b/Tests/Iterator/DateRangeFilterIteratorTest.php
@@ -30,7 +30,7 @@ public function testAccept($size, $expected)
         $this->assertIterator($expected, $iterator);
     }
 
-    public function getAcceptData()
+    public static function getAcceptData()
     {
         $since20YearsAgo = [
             '.git',
diff --git a/Tests/Iterator/DepthRangeFilterIteratorTest.php b/Tests/Iterator/DepthRangeFilterIteratorTest.php
@@ -30,7 +30,7 @@ public function testAccept($minDepth, $maxDepth, $expected)
         $this->assertEquals($expected, $actual);
     }
 
-    public function getAcceptData()
+    public static function getAcceptData()
     {
         $lessThan1 = [
             '.git',
diff --git a/Tests/Iterator/ExcludeDirectoryFilterIteratorTest.php b/Tests/Iterator/ExcludeDirectoryFilterIteratorTest.php
@@ -28,7 +28,7 @@ public function testAccept($directories, $expected)
         $this->assertIterator($expected, $iterator);
     }
 
-    public function getAcceptData()
+    public static function getAcceptData()
     {
         $foo = [
             '.bar',
diff --git a/Tests/Iterator/FileTypeFilterIteratorTest.php b/Tests/Iterator/FileTypeFilterIteratorTest.php
@@ -27,7 +27,7 @@ public function testAccept($mode, $expected)
         $this->assertIterator($expected, $iterator);
     }
 
-    public function getAcceptData()
+    public static function getAcceptData()
     {
         $onlyFiles = [
             'test.py',
diff --git a/Tests/Iterator/FilecontentFilterIteratorTest.php b/Tests/Iterator/FilecontentFilterIteratorTest.php
@@ -45,7 +45,7 @@ public function testFilter(\Iterator $inner, array $matchPatterns, array $noMatc
         $this->assertIterator($resultArray, $iterator);
     }
 
-    public function getTestFilterData()
+    public static function getTestFilterData()
     {
         $inner = new MockFileListIterator();
 
diff --git a/Tests/Iterator/FilenameFilterIteratorTest.php b/Tests/Iterator/FilenameFilterIteratorTest.php
@@ -27,7 +27,7 @@ public function testAccept($matchPatterns, $noMatchPatterns, $expected)
         $this->assertIterator($expected, $iterator);
     }
 
-    public function getAcceptData()
+    public static function getAcceptData()
     {
         return [
             [['test.*'], [], ['test.php', 'test.py']],
diff --git a/Tests/Iterator/MultiplePcreFilterIteratorTest.php b/Tests/Iterator/MultiplePcreFilterIteratorTest.php
@@ -25,7 +25,7 @@ public function testIsRegex($string, $isRegex, $message)
         $this->assertEquals($isRegex, $testIterator->isRegex($string), $message);
     }
 
-    public function getIsRegexFixtures()
+    public static function getIsRegexFixtures()
     {
         yield ['foo', false, 'string'];
         yield [' foo ', false, '" " is not a valid delimiter'];
diff --git a/Tests/Iterator/PathFilterIteratorTest.php b/Tests/Iterator/PathFilterIteratorTest.php
@@ -24,7 +24,7 @@ public function testFilter(\Iterator $inner, array $matchPatterns, array $noMatc
         $this->assertIterator($resultArray, $iterator);
     }
 
-    public function getTestFilterData()
+    public static function getTestFilterData()
     {
         $inner = new MockFileListIterator();
 
diff --git a/Tests/Iterator/SizeRangeFilterIteratorTest.php b/Tests/Iterator/SizeRangeFilterIteratorTest.php
@@ -28,7 +28,7 @@ public function testAccept($size, $expected)
         $this->assertIterator($expected, $iterator);
     }
 
-    public function getAcceptData()
+    public static function getAcceptData()
     {
         $lessThan1KGreaterThan05K = [
             '.foo',
diff --git a/Tests/Iterator/SortableIteratorTest.php b/Tests/Iterator/SortableIteratorTest.php
@@ -68,7 +68,7 @@ public function testAccept($mode, $expected)
         }
     }
 
-    public function getAcceptData()
+    public static function getAcceptData()
     {
         $sortByName = [
             '.bar',
diff --git a/Tests/Iterator/VcsIgnoredFilterIteratorTest.php b/Tests/Iterator/VcsIgnoredFilterIteratorTest.php
@@ -59,7 +59,7 @@ public function testAccept(array $gitIgnoreFiles, array $otherFileNames, array $
         $this->assertIterator($this->toAbsolute($expectedResult), $iterator);
     }
 
-    public function getAcceptData(): iterable
+    public static function getAcceptData(): iterable
     {
         yield 'simple file' => [
             [

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ public function testTestSucceeds(string $operator, string $target, string $teste`
`65`	`65`	`$this->assertTrue($c->test($testedValue));`
`66`	`66`	`}`
`67`	`67`
`68`		`- public function provideMatches(): array`
	`68`	`+ public static function provideMatches(): array`
`69`	`69`	`{`
`70`	`70`	`return [`
`71`	`71`	`['<', '1000', '500'],`
`@@ -91,7 +91,7 @@ public function testTestFails(string $operator, string $target, string $testedVa`
`91`	`91`	`$this->assertFalse($c->test($testedValue));`
`92`	`92`	`}`
`93`	`93`
`94`		`- public function provideNonMatches(): array`
	`94`	`+ public static function provideNonMatches(): array`
`95`	`95`	`{`
`96`	`96`	`return [`
`97`	`97`	`['>', '1000', '500'],`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public function testTest($test, $match, $noMatch)`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`
`52`		`- public function getTestData()`
	`52`	`+ public static function getTestData()`
`53`	`53`	`{`
`54`	`54`	`return [`
`55`	`55`	`['< 2005-10-10', [strtotime('2005-10-09')], [strtotime('2005-10-15')]],`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public function testTest($test, $match, $noMatch)`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`
`54`		`- public function getTestData()`
	`54`	`+ public static function getTestData()`
`55`	`55`	`{`
`56`	`56`	`return [`
`57`	`57`	`['< 1000', ['500', '999'], ['1000', '1500']],`
`@@ -81,7 +81,7 @@ public function getTestData()`
`81`	`81`	`];`
`82`	`82`	`}`
`83`	`83`
`84`		`- public function getConstructorTestData()`
	`84`	`+ public static function getConstructorTestData()`
`85`	`85`	`{`
`86`	`86`	`return [`
`87`	`87`	`[`
Original file line number	Diff line number	Diff line change
`@@ -1274,7 +1274,7 @@ public function testRegexSpecialCharsLocationWithPathRestrictionContainingStartF`
`1274`	`1274`	`$this->assertIterator($this->toAbsoluteFixtures($expected), $finder);`
`1275`	`1275`	`}`
`1276`	`1276`
`1277`		`- public function getContainsTestData()`
	`1277`	`+ public static function getContainsTestData()`
`1278`	`1278`	`{`
`1279`	`1279`	`return [`
`1280`	`1280`	`['', '', []],`
`@@ -1292,7 +1292,7 @@ public function getContainsTestData()`
`1292`	`1292`	`];`
`1293`	`1293`	`}`
`1294`	`1294`
`1295`		`- public function getRegexNameTestData()`
	`1295`	`+ public static function getRegexNameTestData()`
`1296`	`1296`	`{`
`1297`	`1297`	`return [`
`1298`	`1298`	`['~.*t\\.p.+~i'],`
`@@ -1313,7 +1313,7 @@ public function testPath($matchPatterns, $noMatchPatterns, array $expected)`
`1313`	`1313`	`$this->assertIterator($this->toAbsoluteFixtures($expected), $finder);`
`1314`	`1314`	`}`
`1315`	`1315`
`1316`		`- public function getTestPathData()`
	`1316`	`+ public static function getTestPathData()`
`1317`	`1317`	`{`
`1318`	`1318`	`return [`
`1319`	`1319`	`['', '', []],`
Original file line number	Diff line number	Diff line change
`@@ -392,7 +392,7 @@ public static function provider(): array`
`392`	`392`	`return $cases;`
`393`	`393`	`}`
`394`	`394`
`395`		`- public function providerExtended(): array`
	`395`	`+ public static function providerExtended(): array`
`396`	`396`	`{`
`397`	`397`	`$basicCases = self::provider();`
`398`	`398`
`@@ -479,7 +479,7 @@ public function testToRegexMatchingNegatedPatterns(array $gitignoreLines, array`
`479`	`479`	`}`
`480`	`480`	`}`
`481`	`481`
`482`		`- public function provideNegatedPatternsCases(): iterable`
	`482`	`+ public static function provideNegatedPatternsCases(): iterable`
`483`	`483`	`{`
`484`	`484`	`yield [`
`485`	`485`	`[''],`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public function testAccept($filters, $expected)`
`33`	`33`	`$this->assertIterator($expected, $iterator);`
`34`	`34`	`}`
`35`	`35`
`36`		`- public function getAcceptData()`
	`36`	`+ public static function getAcceptData()`
`37`	`37`	`{`
`38`	`38`	`return [`
`39`	`39`	`[[function (\SplFileInfo $fileinfo) { return false; }], []],`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function testAccept($size, $expected)`
`30`	`30`	`$this->assertIterator($expected, $iterator);`
`31`	`31`	`}`
`32`	`32`
`33`		`- public function getAcceptData()`
	`33`	`+ public static function getAcceptData()`
`34`	`34`	`{`
`35`	`35`	`$since20YearsAgo = [`
`36`	`36`	`'.git',`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public function testAccept($directories, $expected)`
`28`	`28`	`$this->assertIterator($expected, $iterator);`
`29`	`29`	`}`
`30`	`30`
`31`		`- public function getAcceptData()`
	`31`	`+ public static function getAcceptData()`
`32`	`32`	`{`
`33`	`33`	`$foo = [`
`34`	`34`	`'.bar',`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public function testAccept($mode, $expected)`
`27`	`27`	`$this->assertIterator($expected, $iterator);`
`28`	`28`	`}`
`29`	`29`
`30`		`- public function getAcceptData()`
	`30`	`+ public static function getAcceptData()`
`31`	`31`	`{`
`32`	`32`	`$onlyFiles = [`
`33`	`33`	`'test.py',`