Skip to content

Make SimpleNormalizer non-readonly #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apfelbox merged 1 commit into from
Jun 26, 2024
Merged

Make SimpleNormalizer non-readonly #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
1.3.1
=====

* (improvement) Make `SimpleNormalizer` non-readonly, to allow it to be mocked.


1.3.0
=====

Expand Down
8 changes: 6 additions & 2 deletions src/Normalizer/SimpleNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,19 @@
use Torr\SimpleNormalizer\Exception\UnsupportedTypeException;

/**
* The normalizer to use in your app.
*
* Can't be readonly, as it needs to be mock-able.
*
* @final
*/
readonly class SimpleNormalizer
class SimpleNormalizer
{
/**
* @param ServiceLocator<SimpleObjectNormalizerInterface> $objectNormalizers
*/
public function __construct (
private ServiceLocator $objectNormalizers,
private readonly ServiceLocator $objectNormalizers,
) {}

/**
Expand Down