Open
Conversation
michaelmaat
approved these changes
Mar 1, 2019
…ading-group-docs * origin/develop: (57 commits) [1.24.0] Update package version and added changelog [HAR-104] Add right default values to top-aligned-labels form elements [HAR-104] Add top-aligned reset styling for form__actions [HAR-104] Add helper and feedback text example to form examples [HAR-104] Add paragraph to form section content example [HAR-104] Fix reload on files in nested folders [HAR-104] Reorder form examples [HAR-104] Add address-level2 as autocomplete attribute for city [HAR-104] Add autocomplete username [HAR-104] Fix discrepancies between form modifiers [HAR-104] Fix attributes for city field [HAR-104] Hide password by default [HAR-104] Fix stylelint error [HAR-104] Remove commented feedback text labels [HAR-104] Rename sections form to advanced form, add content to form section and show link instead of secondary button [HAR-104] Remove top spacing and indent content [HAR-104] Clean up code example markdown [HAR-104] Add control example to form dom structure [HAR-104] Remove no-border modifier, as this is not an issue at the moment in projects [HAR-104] Move input-feedback-text inside field-section ...
|
|
||
| ### Title | ||
|
|
||
| "A title can be used to identify the work, to place it in context, to convey a minimal summary of its contents, and to pique the reader's curiosity." - Wikipedia |
Contributor
There was a problem hiding this comment.
Maybe describe this in your own words, so we don't need to quote Wikipedia? Something like: 'A title describes the content it belongs to and can be used to invoke the reader's curiosity?'
[HAR-152] Fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira id: [HAR-152]
Documentation url: https://harbour.aanzee.cc/feature/HAR-152-heading-group-docs/components/heading-group.html
Checklist
Summary of your proposal
Add documentation about the heading-group component.
Proposed changes in this pull request:
Proposed additions to the CHANGELOG.md
Improvements