Open
Conversation
Bypassed IPs now produce no request context and a thread-local BypassedContextStore flag instead. This mirrors the firewall-java approach (PR #284): every per-request blocking site already short-circuits on "if not context: return", so geo blocking, IP blocklists, bot blocking, route allowlists, blocked user IDs, rate limiting, attack detection, and heartbeat stats all skip naturally — without scattering bypass checks across each call site. Context-less checks (outbound DNS reporting, stored SSRF) consult the BypassedContextStore flag directly so they too become no-ops for traffic from a bypassed IP. Re-enables in the QA suite: - test_bypassed_ip - test_bypassed_ip_for_geo_blocking - test_block_traffic_by_countries - test_outbound_domain_blocking
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the firewall-java approach in AikidoSec/firewall-java#284. For requests from a bypassed IP, the framework entry point now produces no request context and a thread-local
BypassedContextStoreflag instead. Every per-request blocking site already short-circuits on `if not context: return`, so:…all skip naturally — no need to scatter `is_bypassed_ip` checks across each call site.
Context-less checks consult the `BypassedContextStore` flag directly:
Implementation
Tests fixed in QA suite
Test plan
Merge notes
Conflicts with the `skip_tests:` line in `.github/workflows/qa-tests.yml` are expected — also touched by #622 (URL query string) and the wave-attack PR. Resolve by keeping the union of removals.
🤖 Generated with Claude Code
Summary by Aikido
🚀 New Features
⚡ Enhancements
🔧 Refactors
More info