fix: make resource_type optional in ManifestV12 Disabled classes#96
Merged
Sourabhchrs93 merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
dbt manifests (v12) can omit `resource_type` on disabled nodes. This caused 90 validation errors in production when parsing docusign's manifest (`run_473557038`), failing `health_check_per_run`. Made `resource_type` `Optional[...] = None` in all 14 `Disabled*` variant classes (`Disabled` through `Disabled13`). Validated against the actual production manifest from S3 — parses successfully with 3 disabled nodes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mdesmet
approved these changes
Apr 4, 2026
Collaborator
mdesmet
left a comment
mdesmet
left a comment
There was a problem hiding this comment.
This change looks fine, but we may need to check health check if it correctly filters out the disabled nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resource_typefieldOptional[...] = Nonein all 14Disabled*variant classes in ManifestV12resource_typeon disabled nodes, causing Pydantic validation failureshealth_check_per_runtask failing with 90 validation errors forrun_473557038Test plan
s3://altimate-datapilot-prod/prd/tenant=docusign/dbt_core_project_id=11/env_type=PREPROD_375274/batch_id=run_473557038/manifest.json🤖 Generated with Claude Code