Conversation
Marzooqa
force-pushed
the
WCI-250/wasm-mps-add-target-web-build
branch
3 times, most recently
from
c46b9ca to
4086fda
Compare
johnoliverdriscoll
approved these changes
Apr 28, 2026
Contributor
|
@Marzooqa please rebase off latest head |
Add dist/web/js/wasm Makefile target using wasm-pack --target web, which generates an explicit async init() default export. Callers await init() before using any WASM function, eliminating the webpack asyncWebAssembly timing race that left wasm undefined. Export the build via the ./web subpath export so consumers can import directly from @bitgo/wasm-mps/web. Ticket: WCI-250
Marzooqa
force-pushed
the
WCI-250/wasm-mps-add-target-web-build
branch
from
4086fda to
8a4703b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist/web/js/wasmMake target usingwasm-pack --target web, generating an asyncinit()default export that fetches and instantiates the WASM binary before any functions are calleddist/web/js/**/*tofilesinpackage.jsonso the web build is included in the npm publish./websubpath export (@bitgo/wasm-mps/web → dist/web/js/wasm/wasm_mps.js) so browser callers canawait init()before using any WASM functionmake dist/web/js/wasmto thebuild:wasmscriptWhy
The existing
--target bundlerESM build uses a two-file pattern where webpack 5'sasyncWebAssemblymode can resolve the module namespace before__wbg_set_wasmruns, leavingwasmasundefined. The--target webbuild's explicitinit()guarantee eliminates this race entirely — the same pattern used by@silencelaboratories/dkls-wasm-ll-web.Test plan
make dist/web/js/wasmbuilds successfully and producesdist/web/js/wasm/wasm_mps.jswith anexport default initfunctionimport init, { ... } from '@bitgo/wasm-mps/web'; await init(); /* call functions */works in a webpack 5asyncWebAssemblybrowser environment without TypeErrornpm pack --dry-runincludesdist/web/js/**/*Ticket: WCI-250
🤖 Generated with Claude Code