Wp eddsa keygen by alextse-bg · Pull Request #35 · BitGo/advanced-wallets

alextse-bg · 2025-06-20T17:23:27Z

No description provided.

pranavjain97 · 2025-06-20T18:40:59Z

+  'v1.mpc.eddsa.initialize': {
+    post: httpRoute({
+      method: 'POST',
+      path: '/{coin}/mpc/initialize',
+      request: httpRequest({
+        params: { coin: t.string },
+        body: MpcInitializeRequest,
+      }),
+      response: MpcInitializeResponse,
+      description: 'Initialize MPC for EdDSA key generation',
+    }),
+  },


this seems duplicate

pranavjain97 · 2025-06-20T18:41:51Z

+      description: 'Initialize MPC for EdDSA key generation',
+    }),
+  },
+  'v1.key.mpc.init': {


Suggested change

'v1.key.mpc.init': {

'v1.mpc.key.init': {

pranavjain97 · 2025-06-20T18:42:40Z

+      description: 'Initialize Eddsa key generation',
+    }),
+  },
+  'v1.mpc.finalize': {


Suggested change

'v1.mpc.finalize': {

'v1.mpc.key.finalize': {

Just to keep it consistent with v1.multisig.sign nomenclature

pranavjain97 · 2025-06-20T18:49:28Z

+    Buffer.from(keyShare.yShares[3].chaincode, 'hex'),
+  ]).toString('hex');
+
+  const bitgoKeyShare = {


Suggested change

const bitgoKeyShare = {

const sourceToBitGoKeyShare = {

pranavjain97 · 2025-06-20T18:49:51Z

+    Buffer.from(keyShare.yShares[2].chaincode, 'hex'),
+  ]).toString('hex');
+
+  const counterPartyKeyShare = {


Suggested change

const counterPartyKeyShare = {

const sourceToCounterPartyKeyShare = {

pranavjain97 · 2025-06-20T18:54:01Z

+    from: source,
+    to: source === 'user' ? 'backup' : 'user',
+    publicShare: publicKeyShare,
+    privateShare: gpgEncrypt(counterPartyPrivateKeyShare, counterPartyGpgPub),


are you sure you'll have the backup's gpg key in this case? If this is dynamic, woudn't we need a 3rd round since mbe will first need backup's gpg key?

alextse-bg · 2025-06-23T21:02:30Z

-  }
-
  await eddsaUtils.verifyWalletSignatures(
-    userGpgKey.publicKey,


maybe we should use userKey instead of sourceKey, don't know if that will mess up flow

Ticket: WP-4758

TICKET: WP-4756

Ticket: WP-000000

pranavjain97

Nice work! Just requires some polishing

pranavjain97 · 2025-06-25T19:39:13Z

    bitgoAddWalletNock.done();
  });

+  // it('should generate a TSS wallet by calling the enclaved express service', async () => {


Let's get atleast one happy path integration test in with any new feature

pranavjain97 · 2025-06-25T20:03:05Z

+  const sourceIndex = source === 'user' ? 1 : 2;
+  const counterPartyIndex = source === 'user' ? 2 : 1;
+  const bitgoIndex = 3;


You could use KeyIndices from the sdk here

will follow up on

pranavjain97 · 2025-06-25T20:04:22Z

+  const previousState = JSON.parse(
+    req.bitgo.decrypt({
+      input: encryptedData,
+      password: decryptedDataKey.plaintextKey,
+    }),
+  );


nit: could we type this?

pranavjain97 · 2025-06-25T20:05:49Z

+  // Log the constructed keychain for verification
+  debugLogger('Constructed keychain:', {
+    sourcePrivateShare,
+    bitgoToSourceKeyShare,
+    counterPartyToSourceKeyShare,
+    commonKeychain: bitgoKeyChain.commonKeychain,
+  });


Let's remove this, or not log private shares

pranavjain97 · 2025-06-25T20:06:53Z

@@ -0,0 +1,150 @@
+import debug from 'debug';


can we move these files to api/enclaved/mpc?

pranavjain97 · 2025-06-25T20:18:55Z

      description: 'Generate an independent key',
    }),
  },
+  'v1.mpc.initialize': {


Suggested change

'v1.mpc.initialize': {

'v1.mpc.key.initialize': {

pranavjain97 · 2025-06-25T20:19:02Z

+      description: 'Initialize Eddsa key generation',
+    }),
+  },
+  'v1.mpc.finalize': {


pranavjain97 · 2025-06-25T20:19:40Z

+  'v1.mpc.initialize': {
+    post: httpRoute({
+      method: 'POST',
+      path: '/api/{coin}/mpc/initialize',


Suggested change

path: '/api/{coin}/mpc/initialize',

path: '/api/{coin}/mpc/key/initialize',

pranavjain97 · 2025-06-25T20:19:53Z

+  'v1.mpc.finalize': {
+    post: httpRoute({
+      method: 'POST',
+      path: '/api/{coin}/mpc/finalize',


Suggested change

path: '/api/{coin}/mpc/finalize',

path: '/api/{coin}/mpc/key/finalize',

pranavjain97 · 2025-06-25T20:20:22Z

+export interface GenerateDataKeyParams {
+  keyType: 'AES-256' | 'RSA-2048' | 'ECDSA-P256';
+}


Are u sure kms supports 'RSA-2048' | 'ECDSA-P256';? i got an error when using RSA-2048

@alextse-bg can better answer this.

Ticket: WP-4758

pranavjain97

Please do the other changes in quick follow-up

pranavjain97 reviewed Jun 20, 2025

View reviewed changes

alextse-bg commented Jun 23, 2025

View reviewed changes

mohammadalfaiyazbitgo and others added 14 commits June 24, 2025 15:57

wip(mbe): setup flow for eddsa initialization

8562011

Ticket: WP-4758

WIP: integrate getting bitgo gpg key

b9877c2

WIP: integrate the finalize flow

c6fc74a

feat(ebe): added mpc initialize api

6d18173

TICKET: WP-4756

WIP: get e2e first round done

a6da19f

WIP: checkpoint on rd2 user

f29e40f

WIP: e2e user key gen

b45c22f

fix(mbe): update types

d7ecdfd

Ticket: WP-000000

feat(ebe): rebase against previous changes

92710df

feat(mbe, ebe): integrated ebe changes to mbe

db043f4

fix(mbe) update types

cc9c838

WIP: generate eddsa tss wallet

58c5b12

chore: use debug logger and create common functions

715ecb0

Ticket: WP-000000

test: skip eddsa test for follow up

7ff1b6a

Ticket: WP-000000

mohammadalfaiyazbitgo force-pushed the WP-eddsa-keygen branch from e1d7324 to 7ff1b6a Compare June 24, 2025 20:25

mohammadalfaiyazbitgo marked this pull request as ready for review June 24, 2025 20:25

mohammadalfaiyazbitgo enabled auto-merge June 24, 2025 20:25

mohammadalfaiyazbitgo requested a review from pranavjain97 June 24, 2025 20:26

chore(docs): update api spec

bf5e8d6

Ticket: WP-000000

mohammadalfaiyazbitgo mentioned this pull request Jun 25, 2025

wip(mbe): setup flow for eddsa initialization #33

Closed

fix: use correct openpgp version

721ff8b

mohammadalfaiyazbitgo force-pushed the WP-eddsa-keygen branch from 37ad812 to 721ff8b Compare June 25, 2025 19:35

pranavjain97 requested changes Jun 25, 2025

View reviewed changes

test: add integration test & some pr comments

078007a

Ticket: WP-4758

mohammadalfaiyazbitgo requested a review from pranavjain97 June 26, 2025 14:18

pranavjain97 requested a review from islamaminBitGo June 26, 2025 14:36

pranavjain97 approved these changes Jun 26, 2025

View reviewed changes

mohammadalfaiyazbitgo merged commit 144b235 into master Jun 26, 2025
3 checks passed

mohammadalfaiyazbitgo deleted the WP-eddsa-keygen branch June 26, 2025 15:46

	const counterPartyKeyShare = {
	const sourceToCounterPartyKeyShare = {

	path: '/api/{coin}/mpc/initialize',
	path: '/api/{coin}/mpc/key/initialize',

	path: '/api/{coin}/mpc/finalize',
	path: '/api/{coin}/mpc/key/finalize',

Conversation

alextse-bg commented Jun 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pranavjain97 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pranavjain97 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants