feat: improved typing for recovery musig#36
Merged
pranavjain97 merged 1 commit intomasterfrom Jun 20, 2025
Merged
Conversation
| backupPub: t.string, | ||
| apiKey: t.string, | ||
| // TODO: best typing for this, they come from sdk TS types | ||
| unsignedSweepPrebuildTx: t.any, |
Contributor
Author
There was a problem hiding this comment.
@pranavjain97 this one remains untyped by the time, we discussed a couple of solutions with Mohammad but no one seems to work and trying to pass the record with string/unknown raises a conflict with api-ts routes.
We could follow up later in case that some of us discover first how to type this kind of objects that contains a few known fields and a group of anything else.
pranavjain97
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-4769
Description: improved typing and removed most of the any (untyped) regarding to recovery on multisig.