fix: missing params broadcast fail on musig eth rec#45
Merged
mohammadalfaiyazbitgo merged 1 commit intomasterfrom Jun 27, 2025
Merged
fix: missing params broadcast fail on musig eth rec#45mohammadalfaiyazbitgo merged 1 commit intomasterfrom
mohammadalfaiyazbitgo merged 1 commit intomasterfrom
Conversation
mtexeira-simtlix
force-pushed
the
WP-5157
branch
from
dcc4e40 to
a50db48
Compare
| ): ReplayProtectionOptions { | ||
| return ( | ||
| replayProtectionOptions ?? { | ||
| chain: 17000, // 1 if mainnet, 17000 if testnet |
Contributor
Author
There was a problem hiding this comment.
mohammadalfaiyazbitgo
approved these changes
Jun 27, 2025
Contributor
mohammadalfaiyazbitgo
left a comment
mohammadalfaiyazbitgo
left a comment
There was a problem hiding this comment.
please follow up on the comments
Comment on lines
+63
to
+66
| replayProtectionOptions ?? { | ||
| chain: 17000, // 1 if mainnet, 17000 if testnet | ||
| hardfork: 'london', | ||
| } |
Contributor
There was a problem hiding this comment.
use bitgo.env to get the environment return the appropriate options
Comment on lines
+70
to
+77
| export function getDefaultMusigEthGasParams() { | ||
| return { | ||
| gasPrice: 20000000000, | ||
| gasLimit: 200000, | ||
| maxFeePerGas: 20000000000, | ||
| maxPriorityFeePerGas: 10000000000, | ||
| }; | ||
| } |
Contributor
There was a problem hiding this comment.
why is this a function, could it not be const ?
| txPrebuild: { ...unsignedSweepPrebuildTx } as unknown as SignFinalOptions, | ||
| pubs, | ||
| keyList: walletKeys, | ||
| recipients: unsignedSweepPrebuildTx.recipients ?? [], |
Contributor
There was a problem hiding this comment.
should actually error out if there are no recipients
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-5157
Description:
We managed to generate a txHex on a previous PR but when we tried to broadcast it keeps failing.
We were missing some essential parameters that doesn't blocks you from generating the hex but made the tx unbroadcastable and unindexable.
This PR fixes that issue.