Merged
Conversation
pranavjain97
requested changes
Jul 2, 2025
Contributor
pranavjain97
left a comment
pranavjain97
left a comment
There was a problem hiding this comment.
Were you able to test accelerations as well?
Comment on lines
+8
to
+36
| const enclavedExpressClient = req.enclavedExpressClient; | ||
| const reqId = new RequestTracer(); | ||
| const bitgo = req.bitgo; | ||
| const baseCoin = bitgo.coin(req.params.coin); | ||
| const params = req.decoded; | ||
| const walletId = req.params.walletId; | ||
| const wallet = await baseCoin.wallets().get({ id: walletId, reqId }); | ||
|
|
||
| // Log the runtime class name of the wallet object | ||
| logger.info('Wallet runtime class name: %s', wallet?.constructor.name); | ||
| logger.info('Wallet prototype chain: %s', Object.getPrototypeOf(wallet)?.constructor.name); | ||
|
|
||
| if (!wallet) { | ||
| throw new Error(`Wallet ${walletId} not found`); | ||
| } | ||
|
|
||
| // Get the signing keychain based on source | ||
| const keyIdIndex = params.source === 'user' ? KeyIndices.USER : KeyIndices.BACKUP; | ||
| const signingKeychain = await baseCoin.keychains().get({ | ||
| id: wallet.keyIds()[keyIdIndex], | ||
| }); | ||
|
|
||
| if (!signingKeychain || !signingKeychain.pub) { | ||
| throw new Error(`Signing keychain for ${params.source} not found`); | ||
| } | ||
|
|
||
| if (params.pubkey && params.pubkey !== signingKeychain.pub) { | ||
| throw new Error(`Pub provided does not match the keychain on wallet for ${params.source}`); | ||
| } |
Contributor
There was a problem hiding this comment.
I see this code repeating for the 3rd time between consolidation, consolidating unspents and now this. Please re-use code between these 3 APIs
| }; | ||
|
|
||
| // Accelerate transaction | ||
| const result = await wallet.accelerateTransaction(accelerationParams); |
Contributor
There was a problem hiding this comment.
this is the only difference i'm seeing
pranavjain97
requested changes
Jul 4, 2025
| * Fetch wallet and signing keychain, with validation for source and pubkey. | ||
| * Throws with a clear error if not found or mismatched. | ||
| */ | ||
| export async function getWalletAndSigningKeychain({ |
Contributor
There was a problem hiding this comment.
Lets move this under api/master since it is only used within MBE. Also rename to handlerUtils since this isnt coin specific
Contributor
Author
There was a problem hiding this comment.
I will fix this in the later PR.
pranavjain97
approved these changes
Jul 4, 2025
Contributor
pranavjain97
left a comment
pranavjain97
left a comment
There was a problem hiding this comment.
You can do that change in a follow-up.
Contributor
Author
yes, I have tested for multisig and it works well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks: WP-4793
[MBE, EBE] Create UTXO Acceleration Routes