Skip to content

feat!: migrate to npm for better tooling#87

Merged
mohammadalfaiyazbitgo merged 1 commit intomasterfrom
WP-5314/fix-semantic-versions
Jul 24, 2025
Merged

feat!: migrate to npm for better tooling#87
mohammadalfaiyazbitgo merged 1 commit intomasterfrom
WP-5314/fix-semantic-versions

Conversation

@mohammadalfaiyazbitgo
Copy link
Copy Markdown
Contributor

Ticket: WP-5314

This comment was marked as outdated.

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo force-pushed the WP-5314/fix-semantic-versions branch 2 times, most recently from ceceb47 to 7ec7f61 Compare July 24, 2025 18:47

This comment was marked as outdated.

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo force-pushed the WP-5314/fix-semantic-versions branch 2 times, most recently from a8699b5 to 59b1531 Compare July 24, 2025 20:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project from Yarn to npm package manager to follow semantic release GitHub Actions conventions. The change ensures consistency with the semantic release workflow requirements while maintaining all existing functionality.

Key changes:

  • Migrated all build scripts and commands from Yarn to npm
  • Updated lockfile references from yarn.lock to package-lock.json
  • Changed package.json configuration from Yarn's "resolutions" to npm's "overrides"

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Updated build scripts to use npm and changed resolutions to overrides
README.md Updated all command examples from yarn to npm run
Dockerfile Changed dependency installation from yarn to npm ci
CLAUDE.md Updated development command documentation to use npm
.github/workflows/release.yaml Updated build and test commands for release workflow
.github/workflows/build-and-test.yaml Updated all workflow steps to use npm instead of yarn

Comment thread package.json
"scripts": {
"start": "nodemon",
"build": "yarn tsc --build --incremental --verbose . && cp package.json dist/",
"build": "npm run tsc -- --build --incremental --verbose . && cp package.json dist/",
Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The build script uses 'npm run tsc' but could be simplified to just 'tsc' since the tsc script is defined on the next line. Consider using 'tsc --build --incremental --verbose . && cp package.json dist/' for consistency and simplicity.

Suggested change
"build": "npm run tsc -- --build --incremental --verbose . && cp package.json dist/",
"build": "tsc --build --incremental --verbose . && cp package.json dist/",

Copilot uses AI. Check for mistakes.
@mohammadalfaiyazbitgo mohammadalfaiyazbitgo changed the title fix: update release yaml to follow semantic release gha feat!: migrate to npm for better tooling Jul 24, 2025
BREAKING CHAGE: Remove Yarn and Use npm
Ticket: WP-5314
@mohammadalfaiyazbitgo mohammadalfaiyazbitgo force-pushed the WP-5314/fix-semantic-versions branch from 59b1531 to 1e96792 Compare July 24, 2025 20:16
@mohammadalfaiyazbitgo mohammadalfaiyazbitgo merged commit 205bfca into master Jul 24, 2025
4 checks passed
@mohammadalfaiyazbitgo mohammadalfaiyazbitgo deleted the WP-5314/fix-semantic-versions branch July 24, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants